From cf141d4f5ef5c7ae5f416e66fa3ae43edd260675 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alberto=20Mart=C3=ADnez=20P=C3=A9rez?= Date: Sat, 10 Jan 2026 00:21:46 +0000 Subject: [PATCH 1/2] Adding validation to prevent the use of purgeKeysOnRebalance on non-ephemeral clusters --- api/v1/redkeycluster_types.go | 1 + config/crd/bases/redis.inditex.dev_redkeyclusters.yaml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/api/v1/redkeycluster_types.go b/api/v1/redkeycluster_types.go index 4a9774b..2ae84bf 100644 --- a/api/v1/redkeycluster_types.go +++ b/api/v1/redkeycluster_types.go @@ -161,6 +161,7 @@ func (redkeyCluster RedkeyCluster) GetLabels() map[string]string { // RedkeyClusterSpec defines the desired state of RedkeyCluster. // +kubebuilder:validation:XValidation:rule="self.ephemeral || has(self.storage)", message="Ephemeral or storage must be set" // +kubebuilder:validation:XValidation:rule="!(self.ephemeral && has(self.storage))", message="Ephemeral and storage cannot be combined" +// +kubebuilder:validation:XValidation:rule="!(!self.ephemeral && self.purgeKeysOnRebalance == true)", message="Cannot set purgeKeysOnRebalance to true for non-ephemeral clusters" type RedkeyClusterSpec struct { // +kubebuilder:validation:Optional // RedisAuth diff --git a/config/crd/bases/redis.inditex.dev_redkeyclusters.yaml b/config/crd/bases/redis.inditex.dev_redkeyclusters.yaml index e491259..7ad9562 100644 --- a/config/crd/bases/redis.inditex.dev_redkeyclusters.yaml +++ b/config/crd/bases/redis.inditex.dev_redkeyclusters.yaml @@ -7761,6 +7761,8 @@ spec: rule: self.ephemeral || has(self.storage) - message: Ephemeral and storage cannot be combined rule: '!(self.ephemeral && has(self.storage))' + - message: Cannot set purgeKeysOnRebalance to true for non-ephemeral clusters + rule: '!(!self.ephemeral && self.purgeKeysOnRebalance == true)' status: properties: conditions: From d397486722244c3cc5aca8b55d3a1d354b1de903 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alberto=20Mart=C3=ADnez=20P=C3=A9rez?= Date: Mon, 12 Jan 2026 09:31:56 +0100 Subject: [PATCH 2/2] Add copyright info --- config/crd/bases/redis.inditex.dev_redkeyclusters.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/crd/bases/redis.inditex.dev_redkeyclusters.yaml b/config/crd/bases/redis.inditex.dev_redkeyclusters.yaml index 7ad9562..bb1c2c1 100644 --- a/config/crd/bases/redis.inditex.dev_redkeyclusters.yaml +++ b/config/crd/bases/redis.inditex.dev_redkeyclusters.yaml @@ -1,3 +1,6 @@ +# SPDX-FileCopyrightText: 2025 INDUSTRIA DE DISEÑO TEXTIL S.A. (INDITEX S.A.) +# SPDX-License-Identifier: Apache-2.0 + --- apiVersion: apiextensions.k8s.io/v1 kind: CustomResourceDefinition