Fix hasElabroateDestructor and hasAnyDestructor template logic

Author: LunaTheFoxgirl

source/numem/core/memory.d

@@ -161,6 +161,11 @@ T[] nu_malloca(T)(size_t count) {
 /**
     Frees a slice.
 
+    Notes:
+        This function will call destructors for types that have destructors
+        (implicit or otherwise). you may use $(D nogc_zeroinit) to zero fill the
+        slice before freeing if need be.
+
     Params:
         slice = The slice to free.
 */
@@ -169,7 +174,7 @@ void nu_freea(T)(ref T[] slice) {
         foreach(i; 0..slice.length) {
             nu_release(slice[i]);
         }
-    } else static if (hasElaborateDestructor!T) {
+    } else static if (hasAnyDestructor!T) {
         nogc_delete(slice[0..$]);
     }
 

source/numem/core/traits.d

@@ -497,13 +497,10 @@ template hasElaborateCopyConstructor(T) {
     Gets whether type $(D T) has elaborate destructor semantics (is ~this() declared).
 */
 template hasElaborateDestructor(T) {
-    static if (isObjectiveC!T)
-        enum bool hasElaborateDestructor = false;
-    else static if (__traits(isStaticArray, T)) 
+    static if (__traits(isStaticArray, T)) 
         enum bool hasElaborateDestructor = T.sizeof && hasElaborateDestructor!(BaseElemOf!T);
-    else static if (isAggregateType!T)
-        enum bool hasElaborateDestructor = __traits(hasMember, T, "__dtor") ||
-                                      anySatisfy!(.hasElaborateDestructor, Fields!T);
+    else static if (is(T == struct))
+        enum bool hasElaborateDestructor = is(typeof(() { T.init.__xdtor(); }));
     else
         enum bool hasElaborateDestructor = false;
 }
@@ -517,14 +514,19 @@ template hasAnyDestructor(T) {
         enum bool hasAnyDestructor = false;
     else static if (__traits(isStaticArray, T)) 
         enum bool hasAnyDestructor = T.sizeof && hasAnyDestructor!(BaseElemOf!T);
-    else static if (isAggregateType!T)
-        enum bool hasAnyDestructor =
-            is(T == class) ||                       // Classes have implicit destructors 
-            is(T == interface) ||                   // Interfaces have implicit destructors
-            __traits(hasMember, T, "__xdtor") ||
-            __traits(hasMember, T, "__dtor") ||
-            anySatisfy!(.hasAnyDestructor, Fields!T);
-    else
+    else static if (is(T == class))             // Classes have implicit destructors 
+        enum bool hasAnyDestructor = true; 
+    else static if (is(T == interface))         // Interfaces have implicit destructors 
+        enum bool hasAnyDestructor = true;
+    else static if (is(T == struct)) {
+
+        // NOTE: Some types should always report as true, especially if said types
+        //       can be self-referential.
+        static if (is(typeof(() { T.init.__xdtor(); })))
+            enum bool hasAnyDestructor = true;
+        else
+            enum bool hasAnyDestructor = anySatisfy!(.hasAnyDestructor, Fields!T);
+    } else
         enum bool hasAnyDestructor = false;
 }
 

source/numem/optional.d

@@ -94,7 +94,7 @@ public:
     */
     void reset() @trusted nothrow {
         static if (isHeapAllocated!T) {
-            static if (hasElaborateDestructor!T)
+            static if (hasAnyDestructor!T)
                 nogc_trydelete(this.value_);
             else {
                 nu_free(this.value_);