From 789543f5dfd618838a435c090a39b18b990a5ec7 Mon Sep 17 00:00:00 2001
From: Niels Dekker <N.Dekker@lumc.nl>
Date: Mon, 21 Oct 2024 18:28:53 +0200
Subject: [PATCH] BUG: `QuadEdgeMeshPoint` should be properly initialized by
 `{}`
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Defaulted the default-constructor of `QuadEdgeMeshPoint`, and added an
initializer to its data member m_Edge, to ensure that an instance of this type
can be properly initialized by an empty initializer list, `{}`.

Aims to fix the dynamic analysis defects reported by Jon Haitz Legarreta Gorroño
at https://github.com/InsightSoftwareConsortium/ITK/pull/4884#issuecomment-2426580344
---
 Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshPoint.h   | 4 ++--
 Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshPoint.hxx | 6 ------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshPoint.h b/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshPoint.h
index 3a8af924bba..4b1012ce1a1 100644
--- a/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshPoint.h
+++ b/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshPoint.h
@@ -59,7 +59,7 @@ class ITK_TEMPLATE_EXPORT QuadEdgeMeshPoint : public Point<TCoordRep, VPointDime
 #endif
 
 public:
-  QuadEdgeMeshPoint();
+  QuadEdgeMeshPoint() = default;
   QuadEdgeMeshPoint(const Self &) = default;
   QuadEdgeMeshPoint(QuadEdgeMeshPoint &&) = default;
   QuadEdgeMeshPoint &
@@ -118,7 +118,7 @@ class ITK_TEMPLATE_EXPORT QuadEdgeMeshPoint : public Point<TCoordRep, VPointDime
   Initialize();
 
 protected:
-  TQuadEdge * m_Edge; /**< Entry edge for this point into an Onext ring */
+  TQuadEdge * m_Edge{}; /**< Entry edge for this point into an Onext ring */
 };
 } // end namespace itk
 
diff --git a/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshPoint.hxx b/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshPoint.hxx
index ac76a1b63cf..f86e8dd0668 100644
--- a/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshPoint.hxx
+++ b/Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshPoint.hxx
@@ -30,12 +30,6 @@ QuadEdgeMeshPoint<TCoordRep, VPointDimension, TQuadEdge>::Initialize()
   m_Edge = static_cast<TQuadEdge *>(nullptr);
 }
 
-// ---------------------------------------------------------------------
-template <typename TCoordRep, unsigned int VPointDimension, typename TQuadEdge>
-QuadEdgeMeshPoint<TCoordRep, VPointDimension, TQuadEdge>::QuadEdgeMeshPoint()
-{
-  this->Initialize();
-}
 
 // ---------------------------------------------------------------------
 template <typename TCoordRep, unsigned int VPointDimension, typename TQuadEdge>