change pyo3 as optional dependency in native Python Parser#598
Merged
Conversation
zsol
suggested changes
Jan 13, 2022
Contributor
zsol
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks largely good, but I'd like to change two things before merging:
- let's run something in CI to make sure the crate isn't broken without the new feature (at least it should build)
- can we call the new feature
pyorpython? Just in case later we decide to change pyo3 to something else
cargo fmt
Author
Done. Change to |
Codecov Report
@@ Coverage Diff @@
## main #598 +/- ##
==========================================
+ Coverage 94.73% 94.76% +0.03%
==========================================
Files 242 245 +3
Lines 24843 25038 +195
==========================================
+ Hits 23534 23728 +194
- Misses 1309 1310 +1
Continue to review full report at Codecov.
|
zsol
approved these changes
Jan 16, 2022
Contributor
zsol
left a comment
There was a problem hiding this comment.
looks good, thanks for the contribution
This was referenced Jan 28, 2022
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zsol great work on Python Parser. This makes it more accessible outside this project.
Summary
Native Rust parser has
pyo3as a mandatory dependency. Since I am only interested in Python Parser, I want to change to optional dependency to reduce compile and build complexity. With the change,pyo3is still included as a default feature thus everything is the same as before.Pyo3 related code changes (conversion) are segregated together.
Test Plan
The existing test plan should be sufficient since this is feature separation.