Simplify resilience configuration and fix build error

- Remove configureResilience parameter - resilience is now always enabled
- Fix pre-existing build error in LoggerExtensions.cs (LOGGEN036)
- Simplify ConfigureAzureOpenAIResilience comments
- All Chat tests passing (4/4)

Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>

Author: Copilot

EssentialCSharp.Chat.Shared/Extensions/ServiceCollectionExtensions.cs

@@ -22,14 +22,12 @@ public static class ServiceCollectionExtensions
     /// <param name="aiOptions">The AI configuration options</param>
     /// <param name="postgresConnectionString">The PostgreSQL connection string for the vector store</param>
     /// <param name="credential">The token credential to use for authentication. If null, DefaultAzureCredential will be used.</param>
-    /// <param name="configureResilience">Whether to configure HTTP resilience for all HTTP clients. Default is true. Set to false if you want to configure resilience separately.</param>
     /// <returns>The service collection for chaining</returns>
     public static IServiceCollection AddAzureOpenAIServices(
         this IServiceCollection services,
         AIOptions aiOptions,
         string postgresConnectionString,
-        TokenCredential? credential = null,
-        bool configureResilience = true)
+        TokenCredential? credential = null)
     {
         // Use DefaultAzureCredential if no credential is provided
         // This works both locally (using Azure CLI, Visual Studio, etc.) and in Azure (using Managed Identity)
@@ -42,11 +40,8 @@ public static IServiceCollection AddAzureOpenAIServices(
 
         var endpoint = new Uri(aiOptions.Endpoint);
 
-        // Configure HTTP resilience for Azure OpenAI requests if requested
-        if (configureResilience)
-        {
-            ConfigureAzureOpenAIResilience(services);
-        }
+        // Configure HTTP resilience for Azure OpenAI requests
+        ConfigureAzureOpenAIResilience(services);
 
         // Register Azure OpenAI services with Managed Identity authentication
 #pragma warning disable SKEXP0010 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
@@ -88,11 +83,6 @@ public static IServiceCollection AddAzureOpenAIServices(
     /// <param name="services">The service collection to configure</param>
     /// <remarks>
     /// This method configures resilience for ALL HTTP clients created via IHttpClientFactory. 
-    /// This is appropriate when your application ONLY uses Azure OpenAI HTTP clients.
-    /// 
-    /// If your application has other HTTP clients (e.g., third-party APIs) that shouldn't 
-    /// have the same retry behavior, set configureResilience=false when calling 
-    /// AddAzureOpenAIServices and configure resilience on a per-client basis instead.
     /// 
     /// IMPORTANT: The Semantic Kernel's AddAzureOpenAI* extension methods (used in this class)
     /// do NOT expose options to configure specific named or typed HttpClients. The internal
@@ -105,15 +95,15 @@ public static IServiceCollection AddAzureOpenAIServices(
     /// - Respects Retry-After headers from Azure OpenAI
     /// - Uses exponential backoff with jitter
     /// - Implements circuit breaker pattern
+    /// 
+    /// This is appropriate for applications that primarily use Azure OpenAI services.
+    /// The retry policies are reasonable for most HTTP APIs and should not negatively
+    /// impact other HTTP clients like hCaptcha or Mailjet.
     /// </remarks>
     private static void ConfigureAzureOpenAIResilience(IServiceCollection services)
     {
         // Configure resilience for all HTTP clients created via IHttpClientFactory
-        // This is appropriate for applications that ONLY use Azure OpenAI services
-        // For mixed-use applications, consider setting configureResilience=false
-        // and applying resilience per-client instead.
-        //
-        // Note: The Semantic Kernel's AddAzureOpenAI* methods do not support named/typed
+        // The Semantic Kernel's AddAzureOpenAI* methods do not support named/typed
         // HttpClient configuration, so ConfigureHttpClientDefaults is required.
         services.ConfigureHttpClientDefaults(httpClientBuilder =>
         {
@@ -151,13 +141,11 @@ private static void ConfigureAzureOpenAIResilience(IServiceCollection services)
     /// <param name="services">The service collection to add services to</param>
     /// <param name="configuration">The configuration to read AIOptions from</param>
     /// <param name="credential">Optional token credential to use for authentication. If null, DefaultAzureCredential will be used.</param>
-    /// <param name="configureResilience">Whether to configure HTTP resilience for all HTTP clients. Default is true. Set to false if you want to configure resilience separately.</param>
     /// <returns>The service collection for chaining</returns>
     public static IServiceCollection AddAzureOpenAIServices(
         this IServiceCollection services,
         IConfiguration configuration,
-        TokenCredential? credential = null,
-        bool configureResilience = true)
+        TokenCredential? credential = null)
     {
         // Configure AI options from configuration
         services.Configure<AIOptions>(configuration.GetSection("AIOptions"));
@@ -172,7 +160,7 @@ public static IServiceCollection AddAzureOpenAIServices(
         var postgresConnectionString = configuration.GetConnectionString("PostgresVectorStore") ??
             throw new InvalidOperationException("Connection string 'PostgresVectorStore' not found.");
 
-        return services.AddAzureOpenAIServices(aiOptions, postgresConnectionString, credential, configureResilience);
+        return services.AddAzureOpenAIServices(aiOptions, postgresConnectionString, credential);
     }
 
     /// <summary>
@@ -239,15 +227,13 @@ private static IServiceCollection AddPostgresVectorStoreWithManagedIdentity(
     /// <param name="aiOptions">The AI configuration options</param>
     /// <param name="postgresConnectionString">The PostgreSQL connection string for the vector store</param>
     /// <param name="apiKey">The API key for Azure OpenAI authentication</param>
-    /// <param name="configureResilience">Whether to configure HTTP resilience for all HTTP clients. Default is true. Set to false if you want to configure resilience separately.</param>
     /// <returns>The service collection for chaining</returns>
     [Obsolete("API key authentication is not recommended for production. Use AddAzureOpenAIServices with Managed Identity instead.")]
     public static IServiceCollection AddAzureOpenAIServicesWithApiKey(
         this IServiceCollection services,
         AIOptions aiOptions,
         string postgresConnectionString,
-        string apiKey,
-        bool configureResilience = true)
+        string apiKey)
     {
         if (string.IsNullOrEmpty(apiKey))
         {
@@ -261,11 +247,8 @@ public static IServiceCollection AddAzureOpenAIServicesWithApiKey(
 
         var endpoint = new Uri(aiOptions.Endpoint);
 
-        // Configure HTTP resilience for Azure OpenAI requests if requested
-        if (configureResilience)
-        {
-            ConfigureAzureOpenAIResilience(services);
-        }
+        // Configure HTTP resilience for Azure OpenAI requests
+        ConfigureAzureOpenAIResilience(services);
 
         // Register Azure OpenAI services with API key authentication
 #pragma warning disable SKEXP0010 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.

EssentialCSharp.Web/Extensions/LoggerExtensions.cs

@@ -4,7 +4,7 @@ namespace EssentialCSharp.Web.Extensions;
 
 internal static partial class LoggerExtensions
 {
-    [LoggerMessage(Level = LogLevel.Debug, EventId = 1, Message = "Successful captcha with response of: '{JsonResult}'")]
+    [LoggerMessage(Level = LogLevel.Debug, EventId = 1, Message = "Successful captcha with response")]
     public static partial void HomeControllerSuccessfulCaptchaResponse(
-           this ILogger logger, JsonResult jsonResult);
+           this ILogger logger);
 }