-
Notifications
You must be signed in to change notification settings - Fork 748
Open
Labels
minorfixSomething that needs to be fixed (e.g. a hard-coded constant), but that isnt a bugSomething that needs to be fixed (e.g. a hard-coded constant), but that isnt a bug
Description
Problem
The --params-file and --params-mainnet flags (for custom on-chain parameters) are only available via the create-env subcommand. The direct cardano subcommand hardcodes DefaultParams (via def) when calling createTestnetEnv, so there is no way to use custom on-chain params without the two-step flow.
This is a feature gap that makes the two-step flow strictly more capable than the direct path.
Proposed fix
- Add
pOnChainParamsto theoptsTestnetparser inParsers/Cardano.hs. - Thread the resulting
TestnetOnChainParamsthroughCardanoTestnetCliOptions(or a new field). - Pass it to
createTestnetEnvin theNoUserProvidedEnvbranch ofrunCardanoOptionsinParsers/Run.hs, instead ofdef.
~10 lines across Parsers/Cardano.hs and Parsers/Run.hs. Purely additive; existing behaviour unchanged when flags are absent.
Depends on
None (independent)
Type: Consistency fix (feature gap)
Effort: Low (~10 lines)
Risk: Very low
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
minorfixSomething that needs to be fixed (e.g. a hard-coded constant), but that isnt a bugSomething that needs to be fixed (e.g. a hard-coded constant), but that isnt a bug