Fix style of highlighted checkboxes while searching in preferences (#7258)

eludif · web-flow · commit c8798efebad5 · 2020-12-28T15:18:48.000+01:00
* Fix style of checkboxes while searching in preferences (#7226) Previously, highlighted unchecked CheckBoxes seemed to checked (visual bug) * Add change to CHANGELOG.md * fix markdown-lint issue with CHANGELOG.md
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,8 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 
 ### Fixed
 
+- We fixed an issue with the style of highlighted check boxes while searching in preferences. [#7226](https://github.com/JabRef/jabref/issues/7226)
+
 ### Removed
 
 ## [5.2] – 2020-12-24
diff --git a/src/main/java/org/jabref/gui/Base.css b/src/main/java/org/jabref/gui/Base.css
@@ -427,8 +427,11 @@
 }
 
 .check-box > .box > .mark {
-    -fx-background-color: -fx-control-inner-background;
     -fx-padding: 0.2em 0.2em 0.2em 0.2em;
+}
+
+.check-box:selected > .box > .mark {
+    -fx-background-color: -fx-control-inner-background;
     -fx-shape: "M6.61 11.89L3.5 8.78 2.44 9.84 6.61 14l8.95-8.95L14.5 4z";
     -fx-stroke-width: 5;
 }

Original file line number	Diff line number	Diff line change
`@@ -427,8 +427,11 @@`
`427`	`427`	`}`
`428`	`428`
`429`	`429`	`.check-box > .box > .mark {`
`430`		`- -fx-background-color: -fx-control-inner-background;`
`431`	`430`	`-fx-padding: 0.2em 0.2em 0.2em 0.2em;`
	`431`	`+}`
	`432`	`+`
	`433`	`+.check-box:selected > .box > .mark {`
	`434`	`+ -fx-background-color: -fx-control-inner-background;`
`432`	`435`	`-fx-shape: "M6.61 11.89L3.5 8.78 2.44 9.84 6.61 14l8.95-8.95L14.5 4z";`
`433`	`436`	`-fx-stroke-width: 5;`
`434`	`437`	`}`