UP-4797 Adds lifecycle to json layout feed#815
Merged
vertein merged 1 commit intouPortal-Project:masterfrom Jan 30, 2017
Merged
UP-4797 Adds lifecycle to json layout feed#815vertein merged 1 commit intouPortal-Project:masterfrom
vertein merged 1 commit intouPortal-Project:masterfrom
Conversation
Contributor
|
Great idea! |
Contributor
|
I assume this JSON is available via a RESTful endpoint. Is that endpoint versioned? Is this a change that would make us consider incriminating the version of this feed? (I'm not saying it's necessary, but it's probably something we should review & consider.) |
Contributor
Author
|
it's available via the 4.3 layout endpoint (https://github.com/Jasig/uPortal/blob/master/uportal-war/src/main/java/org/apereo/portal/rest/layout/LayoutJsonV43RenderingController.java#L70). I haven't been following the versioning discussion that closely. Have we been making a new controller every time we add some data? Do we up the version on a release? What kind of work are we looking for? |
vertein
force-pushed
the
UP-4794-AddsLifecycle
branch
from
d620391 to
d984a09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Adds lifecycle to JSON layout feed. Useful for those not using the rendering pipeline. For example, AngularJS would like to render a 'Maintenance mode' widget for items in maintenance mode.
Example:
"content": [
{
"_objectType": "portlet",
"url": "/uPortal/api/v4-3/portlet/what-is-uportal.html",
"iconUrl": "/uPortal/media/skins/icons/mobile/feedback.png",
"ID": "u26l1n1110",
"chanID": "53",
"description": "Description of uPortal.",
"fragment": "0",
"precedence": "80.0",
"fname": "what-is-uportal",
"locale": "en_US",
"name": "Welcome to uPortal",
"timeout": "10000",
"title": "Welcome to uPortal",
"typeID": "3",
"deleteAllowed": "false",
"moveAllowed": "false",
"windowState": "normal",
"portletMode": "view",
"portletName": "cms",
"lifecycleState": "PUBLISHED",
"webAppName": "/SimpleContentPortlet",
"parameters": {
"disableDynamicTitle": "true",
"configurable": "true",
"iconUrl": "/ResourceServingWebapp/rs/tango/0.8.90/32x32/mimetypes/text-html.png",
"mobileIconUrl": "/uPortal/media/skins/icons/mobile/feedback.png"
}
},