Migrate rustc_lint::EqInternalMethodImplemented to Diagnostic

Author: GuillaumeGomez

compiler/rustc_lint/src/disallowed_pass_by_ref.rs

@@ -26,7 +26,7 @@ impl<'tcx> LateLintPass<'tcx> for DisallowedPassByRef {
                 if cx.tcx.trait_impl_of_assoc(ty.hir_id.owner.to_def_id()).is_some() {
                     return;
                 }
-                if let Some(t) = path_for_pass_by_value(cx, inner_ty) {
+                if let Some(t) = path_for_rustc_pass_by_value(cx, inner_ty) {
                     cx.emit_span_lint(
                         DISALLOWED_PASS_BY_REF,
                         ty.span,

compiler/rustc_lint/src/lints.rs

@@ -3951,7 +3951,7 @@ pub(crate) struct MalformedOnConstAttrLint {
     pub span: Span,
 }
 
-#[derive(LintDiagnostic)]
+#[derive(Diagnostic)]
 #[diag("`Eq::assert_receiver_is_total_eq` should never be implemented by hand")]
 #[note("this method was used to add checks to the `Eq` derive macro")]
 pub(crate) struct EqInternalMethodImplemented;

tests/ui/deriving/internal_eq_trait_method_impls.stderr

@@ -28,9 +28,9 @@ error: `Eq::assert_receiver_is_total_eq` should never be implemented by hand
 LL |     fn assert_receiver_is_total_eq(&self) {}
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
+   = note: this method was used to add checks to the `Eq` derive macro
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #152336 <https://github.com/rust-lang/rust/issues/152336>
-   = note: this method was used to add checks to the `Eq` derive macro
 note: the lint level is defined here
   --> $DIR/internal_eq_trait_method_impls.rs:1:21
    |