Adapt to CC.finish!(...) signature changes#620
Closed
serenity4 wants to merge 1 commit intoJuliaDebug:masterfrom
Closed
Adapt to CC.finish!(...) signature changes#620serenity4 wants to merge 1 commit intoJuliaDebug:masterfrom
CC.finish!(...) signature changes#620serenity4 wants to merge 1 commit intoJuliaDebug:masterfrom
Conversation
Member
|
Oops, I totally missed that PR #621 and created a new one. |
Member
|
Let me replace this with #621. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in JuliaLang/julia#57248 caused the
CC.finish!(::CthulhuInterpreter, ...)override to be ignored, skipping the creation of theOptimizedSource.The following testset fails:
Cthulhu.jl/test/test_Cthulhu.jl
Lines 381 to 412 in a8fcae8
because the code now contains calls to
getproperty:Not sure if we want to update the testset or have a rule to ignore
getpropertycalls, but in any case this can be merged to have nightly working.