Verify LLVM IR on CI by default. (#375)

Author: vchuravy

src/GPUCompiler.jl

@@ -9,12 +9,6 @@ using ExprTools: splitdef, combinedef
 
 using Libdl
 
-const to = TimerOutput()
-
-timings() = (TimerOutputs.print_timer(to); println())
-
-enable_timings() = (TimerOutputs.enable_debug_timings(GPUCompiler); return)
-
 include("utils.jl")
 
 # compiler interface and implementations

src/driver.jl

@@ -402,7 +402,7 @@ const __llvm_initialized = Ref(false)
             end
         end
 
-        if ccall(:jl_is_debugbuild, Cint, ()) == 1
+        if should_verify()
             @timeit_debug to "verification" verify(ir)
         end
     end

src/irgen.jl

@@ -653,7 +653,7 @@ function add_kernel_state!(mod::LLVM.Module)
                 end
             end
         end
-        return nothing
+        return nothing # do not claim responsibility
     end
     for (f, new_f) in workmap
         # use a value mapper for rewriting function arguments

src/utils.jl

@@ -2,6 +2,21 @@ defs(mod::LLVM.Module)  = filter(f -> !isdeclaration(f), collect(functions(mod))
 decls(mod::LLVM.Module) = filter(f ->  isdeclaration(f) && !LLVM.isintrinsic(f),
                                  collect(functions(mod)))
 
+## timings
+
+const to = TimerOutput()
+
+timings() = (TimerOutputs.print_timer(to); println())
+
+enable_timings() = (TimerOutputs.enable_debug_timings(GPUCompiler); return)
+
+
+## debug verification
+
+should_verify() = ccall(:jl_is_debugbuild, Cint, ()) == 1 ||
+                  Base.JLOptions().debug_level >= 2 ||
+                  parse(Bool, get(ENV, "CI", "false"))
+
 
 ## lazy module loading
 

test/metal.jl

@@ -85,7 +85,7 @@ end
 
 ############################################################################################
 
-@testset "asm" begin
+Sys.isapple() && @testset "asm" begin
 
 @testset "smoke test" begin
     kernel() = return

test/runtests.jl

@@ -19,9 +19,9 @@ GPUCompiler.enable_timings()
 include("native.jl")
 include("ptx.jl")
 include("spirv.jl")
-include("gcn.jl")
 include("bpf.jl")
-if Sys.isapple() && Base.thisminor(VERSION) == v"1.8"
+if VERSION >= v"1.8-"
+    include("gcn.jl")
     include("metal.jl")
 end
 include("examples.jl")