Skip to content

rename sub/slice -> view#16972

Merged
JeffBezanson merged 2 commits intomasterfrom
sb/sub2view
Jun 18, 2016
Merged

rename sub/slice -> view#16972
JeffBezanson merged 2 commits intomasterfrom
sb/sub2view

Conversation

@simonbyrne
Copy link
Copy Markdown
Member

@simonbyrne simonbyrne commented Jun 16, 2016

fixes #16846

tkelman
tkelman reviewed Jun 17, 2016
View reviewed changes
base/docs/helpdb/Base.jl

"""
sub(A, inds...)
view(A, inds...)
Copy link
Copy Markdown
Contributor

@tkelman tkelman Jun 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rst docs too

Copy link
Copy Markdown
Member Author

@simonbyrne simonbyrne Jun 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@simonbyrne simonbyrne changed the title WIP: rename sub/slice -> view rename sub/slice -> view Jun 17, 2016
@simonbyrne
Copy link
Copy Markdown
Member Author

simonbyrne commented Jun 17, 2016

Okay, looks like this is now working.

@timholy
Copy link
Copy Markdown
Member

timholy commented Jun 17, 2016

👍 Of course, note that we have multiple view types now: ReshapedArray and the unexported PermutedDimsArray being two new ones for julia-0.5. Still, I think SubArray is the canonical view, so this is fine.

@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Jun 17, 2016

Should SubArray be renamed to ArrayView while we're at it or would that be too disruptive?

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Jun 18, 2016

Stefan, I think we should worry about that in v0.6 as we do a more bottom-up refactoring.

@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Jun 18, 2016

Sounds good to me.

@simonbyrne
Copy link
Copy Markdown
Member Author

simonbyrne commented Jun 18, 2016

Any idea why appveyor is failing?

@JeffBezanson JeffBezanson merged commit 9d2a40b into master Jun 18, 2016
@tkelman tkelman deleted the sb/sub2view branch June 18, 2016 21:11
@tkelman
Copy link
Copy Markdown
Contributor

tkelman commented Jun 18, 2016

#16556

@simonbyrne simonbyrne mentioned this pull request Jun 19, 2016
Merged
simonbyrne added a commit that referenced this pull request Jun 19, 2016
@simonbyrne
add #16972 to NEWS.md
ea3b373
vtjnash added a commit that referenced this pull request Jun 23, 2016
@vtjnash
Merge pull request #17021 from JuliaLang/sb/sub2view-changes
1f74697 
add #16972 to NEWS.md
@ranjanan ranjanan mentioned this pull request Jun 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change sub behaviour to match getindex, possibly rename.

6 participants

@simonbyrne @timholy @StefanKarpinski @vtjnash @tkelman @JeffBezanson