Skip to content

Rename num/den to numerator/denominator#19246

Merged
KristofferC merged 3 commits intoJuliaLang:masterfrom
fredrikekre:fe/numden
Nov 10, 2016
Merged

Rename num/den to numerator/denominator#19246
KristofferC merged 3 commits intoJuliaLang:masterfrom
fredrikekre:fe/numden

Conversation

@fredrikekre
Copy link
Copy Markdown
Member

@fredrikekre fredrikekre commented Nov 7, 2016

Fix #19233

Think I found all the places. Also moved docstrings inline.

StefanKarpinski
StefanKarpinski requested changes Nov 7, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an entry in NEWS.md. Looks good otherwise!

@fredrikekre
Copy link
Copy Markdown
Member Author

fredrikekre commented Nov 7, 2016

@StefanKarpinski Link to issue or PR? Seems like all entries in NEWS.md are linked to the issue, but in deprecated.jl the references are for the PR.

@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Nov 7, 2016

I don't think it really matters which as long as there's an entry and a trail of breadcrumbs.

@fredrikekre
Copy link
Copy Markdown
Member Author

fredrikekre commented Nov 9, 2016

I don't have the power of the button, but I think this is all done?

@KristofferC
Copy link
Copy Markdown
Member

KristofferC commented Nov 9, 2016

LGTM

nalimilan
nalimilan reviewed Nov 9, 2016
View reviewed changes
NEWS.md Outdated

* `is` has been deprecated in favor of `===` (which used to be an alias for `is`) ([#17758]).

* `num` and `den` has been deprecated in favor of `numerator` and `denominator` respectively ([#19233]).
Copy link
Copy Markdown
Member

@nalimilan nalimilan Nov 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has -> have

Copy link
Copy Markdown
Member Author

@fredrikekre fredrikekre Nov 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Nov 9, 2016

There seems to be a modicum of disagreement on the original issue, so let's that discussion play out before merging this.

@martinholters
Copy link
Copy Markdown
Member

martinholters commented Nov 10, 2016

I think that discussion is resolved in favor of the change. Merge?

@KristofferC KristofferC merged commit 5fa05dc into JuliaLang:master Nov 10, 2016
@KristofferC
Copy link
Copy Markdown
Member

KristofferC commented Nov 10, 2016

Argh, I think I left the CI skip message in the squash merge. Sorry :/

@fredrikekre fredrikekre deleted the fe/numden branch November 10, 2016 14:03
@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Nov 11, 2016 •
edited
Loading

Not your fault: controlling the CI tools via commit messages is an incredibly dumb, bad UX design.

fcard pushed a commit to fcard/julia that referenced this pull request Feb 28, 2017
@fredrikekre @fcard
Rename num/den to numerator/denominator (JuliaLang#19246)
349f9ef 
* rename num/den -> numerator/denominator

* added news entry [ci skip]

* grammar [ci skip]
Sacha0 added a commit to Sacha0/julia that referenced this pull request May 18, 2017
@Sacha0
Fix PR number in NEWS.md entry for num/den rename (JuliaLang#19246).
3685606
@fredrikekre fredrikekre mentioned this pull request May 18, 2017
Merged
Sacha0 added a commit to Sacha0/julia that referenced this pull request May 18, 2017
@Sacha0
Fix PR number in NEWS.md entry for num/den rename (JuliaLang#19246).
ee05c20
ararslan pushed a commit that referenced this pull request May 18, 2017
@Sacha0 @ararslan
Fix PR number in NEWS.md entry for num/den rename (#19246). (#21943)
b94cca1
tkelman pushed a commit that referenced this pull request Jun 3, 2017
@Sacha0 @tkelman
Fix PR number in NEWS.md entry for num/den rename (#19246). (#21943)
fb3cdff 
(cherry picked from commit b94cca1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nalimilan nalimilan nalimilan left review comments

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fredrikekre @StefanKarpinski @KristofferC @martinholters @nalimilan