Skip to content

Commit 36974f0

Browse files
committed
Add public_aws_ecr profile for using public ECR images
1 parent b4d89cf commit 36974f0

File tree

6 files changed

+72
-7
lines changed

6 files changed

+72
-7
lines changed

.github/workflows/awsfulltest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
{
2525
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/hic/results-${{ github.sha }}"
2626
}
27-
profiles: test_full,aws_tower
27+
profiles: test_full,public_aws_ecr
2828
- uses: actions/upload-artifact@v3
2929
with:
3030
name: Tower debug log file

.github/workflows/awstest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
{
2323
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/hic/results-test-${{ github.sha }}"
2424
}
25-
profiles: test,aws_tower
25+
profiles: test,public_aws_ecr
2626
- uses: actions/upload-artifact@v3
2727
with:
2828
name: Tower debug log file

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@
33
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
44
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

6+
## v2.0.1dev
7+
8+
### `Added`
9+
10+
- Added public_aws_ecr profile for using containers stored on ECR.
11+
12+
### `Fixed`
13+
614
## v2.0.0 - 2023-01-12
715

816
### `Added`

conf/public_aws_ecr.config

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
/*
2+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3+
AWS ECR Config
4+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5+
Config to set public AWS ECR images wherever possible
6+
This improves speed when running on AWS infrastructure.
7+
Use this as an example template when using your own private registry.
8+
----------------------------------------------------------------------------------------
9+
*/
10+
11+
docker.registry = 'public.ecr.aws'
12+
podman.registry = 'public.ecr.aws'
13+
14+
process {
15+
withName: '.*:BOWTIE2_ALIGN' {
16+
container = 'quay.io/biocontainers/mulled-v2-ac74a7f02cebcfcc07d8e8d1d750af9c83b4d45a:a0ffedb52808e102887f6ce600d092675bf3528a-0'
17+
}
18+
withName: '.*:BUILD_CONTACT_MAPS' {
19+
container = 'quay.io/nf-core/ubuntu:20.04'
20+
}
21+
withName: '.*:COMBINE_MATES' {
22+
container = 'quay.io/biocontainers/mulled-v2-c6ff206325681cbb9c9ef890bb8de554172c0483:713df51cd897ceb893b9a6e6420f527d83c2ed95-0'
23+
}
24+
withName: '.*:COOLTOOLS_EIGSCIS' {
25+
container = 'quay.io/biocontainers/mulled-v2-c81d8d6b6acf4714ffaae1a274527a41958443f6:cc7ea58b8cefc76bed985dcfe261cb276ed9e0cf-0'
26+
}
27+
withName: '.*:GET_RESTRICTION_FRAGMENTS' {
28+
container = 'quay.io/biocontainers/mulled-v2-c6ff206325681cbb9c9ef890bb8de554172c0483:713df51cd897ceb893b9a6e6420f527d83c2ed95-0'
29+
}
30+
withName: '.*:GET_VALID_INTERACTION' {
31+
container = 'quay.io/biocontainers/mulled-v2-c6ff206325681cbb9c9ef890bb8de554172c0483:713df51cd897ceb893b9a6e6420f527d83c2ed95-0'
32+
}
33+
withName: '.*:GET_VALID_INTERACTION_DNASE' {
34+
container = 'quay.io/biocontainers/mulled-v2-c6ff206325681cbb9c9ef890bb8de554172c0483:713df51cd897ceb893b9a6e6420f527d83c2ed95-0'
35+
}
36+
withName: '.*:ICE_NORMALIZATION' {
37+
container = 'quay.io/biocontainers/mulled-v2-c6ff206325681cbb9c9ef890bb8de554172c0483:713df51cd897ceb893b9a6e6420f527d83c2ed95-0'
38+
}
39+
withName: '.*:MERGE_STATS' {
40+
container = 'quay.io/biocontainers/mulled-v2-c6ff206325681cbb9c9ef890bb8de554172c0483:713df51cd897ceb893b9a6e6420f527d83c2ed95-0'
41+
}
42+
withName: '.*:MERGE_VALID_INTERACTION' {
43+
container = 'quay.io/nf-core/ubuntu:20.04'
44+
}
45+
withName: '.*:SAMPLESHEET_CHECK' {
46+
container = 'quay.io/biocontainers/python:3.8.3'
47+
}
48+
withName: '.*:SPLIT_COOLER_DUMP' {
49+
container = 'quay.io/nf-core/ubuntu:20.04'
50+
}
51+
withName: '.*:TRIM_READS' {
52+
container = 'quay.io/nf-core/ubuntu:20.04'
53+
}
54+
}

modules/local/hicpro/run_ice.nf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
process ICE_NORMALIZATION{
1+
process ICE_NORMALIZATION {
22
tag "$meta.id"
33
label 'process_high_memory'
44

55
conda "conda-forge::python=3.9 bioconda::iced=0.5.10 conda-forge::numpy=1.22.3"
66
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
77
'https://depot.galaxyproject.org/singularity/mulled-v2-c6ff206325681cbb9c9ef890bb8de554172c0483:713df51cd897ceb893b9a6e6420f527d83c2ed95-0' :
8-
'quay.io/biocontainers/mulled-v2-c6ff206325681cbb9c9ef890bb8de554172c0483:713df51cd897ceb893b9a6e6420f527d83c2ed95-0'}"
8+
'quay.io/biocontainers/mulled-v2-c6ff206325681cbb9c9ef890bb8de554172c0483:713df51cd897ceb893b9a6e6420f527d83c2ed95-0' }"
99

1010
input:
1111
tuple val(meta), val(res), path(rmaps), path(bed)

nextflow.config

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,13 @@ params {
5454
ligation_site='GATCGATC,GATCANTC,GANTGATC,GANTANTC'
5555
}
5656
}
57-
57+
5858
min_restriction_fragment_size = 0
5959
max_restriction_fragment_size = 0
6060
min_insert_size = 0
6161
max_insert_size = 0
6262
save_pairs_intermediates = false
63-
63+
6464
// Dnase Hi-C
6565
dnase = false
6666
min_cis_dist = 0
@@ -111,7 +111,7 @@ params {
111111
validate_params = true
112112
show_hidden_params = false
113113
schema_ignore_params = 'genomes,digest'
114-
114+
115115
// Config options
116116
custom_config_version = 'master'
117117
custom_config_base = "https://raw.githubusercontent.com/nf-core/configs/${params.custom_config_version}"
@@ -215,6 +215,9 @@ profiles {
215215
executor.cpus = 16
216216
executor.memory = 60.GB
217217
}
218+
public_aws_ecr {
219+
includeConfig 'conf/public_aws_ecr.config'
220+
}
218221
test { includeConfig 'conf/test.config' }
219222
test_full { includeConfig 'conf/test_full.config' }
220223
}

0 commit comments

Comments
 (0)