forked from project-chip/connectedhomeip
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy path.pullapprove.yml
More file actions
346 lines (328 loc) · 10 KB
/
.pullapprove.yml
File metadata and controls
346 lines (328 loc) · 10 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
version: 3
# https://developer.github.com/v3/previews/#draft-pull-requests
github_api_version: "shadow-cat-preview"
############################################################
# Overrides
############################################################
overrides:
- if: "'hotfix' in labels"
status: success
explanation: "Hotfix label added, bypassing reviews"
############################################################
# Draft PRs
############################################################
- if: "draft"
status: pending
explanation: "PR is draft, pending review"
############################################################
# License Checks
############################################################
- if: "'*license/cla*' not in statuses.successful"
status: pending
explanation: "CLA must be agreed to by all contributors"
############################################################
# Conditions to Skip Review
############################################################
- if: "base.ref != 'master'"
status: success
explanation: "Review not required unless merging to master"
############################################################
# Require Issues
############################################################
# disabling until we have PRs up to date
# - if: "'*issue*' not in statuses.successful"
# status: failure
# explanation: "An issue is required for all PRs"
############################################################
# Fast tracking
############################################################
- if: "'fast track' in labels"
status: success
explanation: "PR has been fast tracked, bypassing reviews"
############################################################
# Approved by matter-sdk-maintainers
############################################################
- if: "'sdk-maintainer-approved' in labels and len(groups.approved.include('sdk-maintainers')) >= 1"
status: success
explanation: "Approved by SDK maintainer and label is set."
############################################################
# Notifications
############################################################
notifications:
############################################################
# New contributors
############################################################
- when: pull_request.opened
if: "author_association == 'FIRST_TIME_CONTRIBUTOR'"
comment: |
Hey @{{ author }}, thanks for the PR! The review will start once
the tests and CI checks have passed. If they don't, please review
the logs and try to fix the issues (ask for help if you can't
figure it out). A reviewer will be assigned once the tests are
passing and they'll walk you through getting the PR finished
and merged.
groups:
############################################################
# Shared Reviewer Groups
############################################################
shared-reviewers-amazon:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-amazon]
reviews:
request: 0 # Do not auto-add
shared-reviewers-apple:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-apple]
reviews:
request: 0 # Do not auto-add
shared-reviewers-bosch:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-bosch]
reviews:
request: 0 # Do not auto-add
shared-reviewers-comcast:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-comcast]
reviews:
request: 0 # Do not auto-add
shared-reviewers-cablelabs:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-cablelabs]
reviews:
request: 0 # Do not auto-add
shared-reviewers-dyson:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-dyson]
reviews:
request: 0 # Do not auto-add
shared-reviewers-espressif:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-espressif]
reviews:
request: 0 # Do not auto-add
shared-reviewers-google:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-google]
reviews:
request: 0 # Do not auto-add
shared-reviewers-geo:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-geo]
reviews:
request: 0 # Do not auto-add
shared-reviewers-grundfos:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-grundfos]
reviews:
request: 0 # Do not auto-add
shared-reviewers-irobot:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-irobot]
reviews:
request: 0 # Do not auto-add
shared-reviewers-lg:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-lg]
reviews:
request: 0 # Do not auto-add
shared-reviewers-logitech:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-logitech]
reviews:
request: 0 # Requested to be only on demand
shared-reviewers-nordic:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-nordic]
reviews:
request: 0 # Do not auto-add
shared-reviewers-nxp:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-nxp]
reviews:
request: 0 # Do not auto-add
shared-reviewers-samsung:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-samsung]
reviews:
request: 0 # Do not auto-add
shared-reviewers-eve:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-eve]
reviews:
request: 0 # Do not auto-add
# shared-reviewers-signify disabled for now, because the reviewers-signify
# team is empty and pullapprove seems to mis-handle that badly and treats
# _all_ reviewers as being in this group.
#
# See https://github.com/dropseed/pullapprove/issues/71
#
# shared-reviewers-signify:
# type: optional
# conditions:
# - files.include('*')
# reviewers:
# teams: [reviewers-signify]
# reviews:
# request: 0 # Do not auto-add
shared-reviewers-silabs:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-silabs]
reviews:
request: 0 # Do not auto-add
shared-reviewers-somfy:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-somfy]
reviews:
request: 0 # Do not auto-add
shared-reviewers-tcl:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-tcl]
reviews:
request: 0 # Do not auto-add
shared-reviewers-qorvo:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-qorvo]
reviews:
request: 0 # Do not auto-add
shared-reviewers-velux:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-velux]
reviews:
request: 0 # Do not auto-add
sdk-maintainers:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [matter-sdk-maintainers]
reviews:
request: 0 # Do not auto-add
############################################################
# Folder specific review requirements. A PR must meet all
# folder specific review requirements for all folders that
# it touches with specific requirements defined.
############################################################
folder-reviewers-scripts-build-integrations-docker:
type: optional
conditions:
- "files.include('scripts/build/*') or files.include('integrations/docker/*')"
reviewers:
users:
- andy31415
reviews:
# 1 review request will be sent at a time
request: 1
folder-reviewers-google:
type: required
conditions:
- "files.include('examples/chef/*') or files.include('integrations/cloudbuild/*')"
requirements:
- "len(groups.approved.include('shared-reviewers-google')) >= 1 or \
len(groups.approved.include('shared-reviewers-*')) >= 2"
reviews:
required: 0
folder-reviewers-apple:
type: required
conditions:
- "files.include('src/darwin/*').exclude('src/darwin/Framework/CHIP/zap-generated/*') or \
files.include('src/platform/Darwin/*') or \
files.include('examples/darwin-framework-tool/*')"
reviewers:
teams: [reviewers-apple]
reviews:
request: 0
required: 1
############################################################
# Base Required Reviewers. If PR touches a path not covered
# by any folder specific review requirements.
############################################################
required-reviewers:
description: >
[Required
Reviewers](https://github.com/project-chip/connectedhomeip/blob/master/CONTRIBUTING.md#review-requirements)
This is the main group of required reviews for general pull
requests.
type: required
conditions:
# If PR touches a region not covered by any custom review paths, base condition is required.
- "files\
.exclude('examples/chef/*')\
.exclude('integrations/cloudbuild/*')\
.exclude('src/darwin/*')\
.exclude('src/platform/Darwin/*')\
.exclude('examples/darwin-framework-tool/*') or \
files.include('src/darwin/Framework/CHIP/zap-generated/*')"
requirements:
- len(groups.approved.include('shared-reviewers-*')) >= 2
reviews:
required: 0
labels:
approved: "review - approved"
pending: "review - pending"
rejected: "review - changed requested"