Skip to content

Remove length limitation for file names and other maintenance#74

Merged
dzenanz merged 4 commits into
Kitware:masterfrom
dzenanz:master
May 15, 2019
Merged

Remove length limitation for file names and other maintenance#74
dzenanz merged 4 commits into
Kitware:masterfrom
dzenanz:master

Conversation

@dzenanz
Copy link
Copy Markdown
Member

@dzenanz dzenanz commented May 13, 2019

Comment thread src/metaImageUtils.h
string_format function was taken from:
https://stackoverflow.com/a/26221725/276168
It was released into public domain by its author.
@dzenanz
Copy link
Copy Markdown
Member Author

dzenanz commented May 14, 2019

I amended the commit. The CI is failing due to MetaIO's tests being largely duplicated in ITK. Those tests will need to be updated after ITK starts using this version of MetaIO.

dzenanz added 2 commits May 14, 2019 11:37
Write fields on line 45 of testMeta11Form.cxx had 6 elements,
but read fields only 3. So iterator increment at old line 209
went beyond end, causing a crash.
Level 6 is noticeably slower while providing only
slightly better compression for typical data.
@dzenanz dzenanz changed the title Remove length limitation for file names Remove length limitation for file names and other maintenance May 14, 2019
Copy link
Copy Markdown
Collaborator

@mathstuf mathstuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@dzenanz dzenanz merged commit bffb2ef into Kitware:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MetaIO limits file names to 255 characters

4 participants