From 30128a7f0d0245ca638a60137574a4b175a5cdbb Mon Sep 17 00:00:00 2001 From: wookieejedi Date: Thu, 23 Jan 2025 12:04:28 -0500 Subject: [PATCH] Make Settings Tab always consistent Following user testing, in instructions throughout FSO websites and discussions, the `Settings` tab in Knossos is commonly referred to. The standalone TC mode changes that name to `Options` which was b/c the name `Settings` was already used in the mod `Settings` button on the Home Screen. That button is more of an `Advanced` settings especially for TC mode, so this PR proposes changing keeping the global `Settings` tab as `Settings` so that users will always understand instructions from community members and the QuickStart Guide regarding which tab controls global settings. This PR also proposes changing the default name of the `Settings` button on the TC mode home screen to `Advanced` by default, but of course mods can set this text to whatever they want since TC mode exposes that option. Would be happy to dicuss if useful, too, thanks! --- Knossos.NET/ViewModels/Windows/MainWindowViewModel.cs | 2 +- Knossos.NET/Views/CustomHomeView.axaml | 2 +- Knossos.NET/Views/CustomHomeView.axaml.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Knossos.NET/ViewModels/Windows/MainWindowViewModel.cs b/Knossos.NET/ViewModels/Windows/MainWindowViewModel.cs index 7781a0de..402a3d2d 100644 --- a/Knossos.NET/ViewModels/Windows/MainWindowViewModel.cs +++ b/Knossos.NET/ViewModels/Windows/MainWindowViewModel.cs @@ -221,7 +221,7 @@ private void FillMenuItemsCustomMode(int defaultSelectedIndex) if (CustomLauncher.MenuDisplayGlobalSettingsEntry && GlobalSettingsView != null) { - MenuItems.Add(new MainViewMenuItem(GlobalSettingsView, "avares://Knossos.NET/Assets/general/menu_settings.png", "Options", "Change launcher and FSO engine settings")); + MenuItems.Add(new MainViewMenuItem(GlobalSettingsView, "avares://Knossos.NET/Assets/general/menu_settings.png", "Settings", "Change launcher and FSO engine settings")); } if (CustomLauncher.MenuDisplayDebugEntry && DebugView != null) diff --git a/Knossos.NET/Views/CustomHomeView.axaml b/Knossos.NET/Views/CustomHomeView.axaml index 623640ad..14e0c38b 100644 --- a/Knossos.NET/Views/CustomHomeView.axaml +++ b/Knossos.NET/Views/CustomHomeView.axaml @@ -137,7 +137,7 @@ - diff --git a/Knossos.NET/Views/CustomHomeView.axaml.cs b/Knossos.NET/Views/CustomHomeView.axaml.cs index d57f7da1..87011d71 100644 --- a/Knossos.NET/Views/CustomHomeView.axaml.cs +++ b/Knossos.NET/Views/CustomHomeView.axaml.cs @@ -73,7 +73,7 @@ public CustomHomeView() Log.Add(Log.LogSeverity.Error, "CustomHomeView.Constructor()", ex); } - //Home Buttons Custimizations + //Home Buttons Customizations try { if (CustomLauncher.HomeButtonConfigs != null && CustomLauncher.HomeButtonConfigs.Any())