Replace deprecated Organization\Teams api calls - #860
Merged
Conversation
- \Github\Api\Organization\Teams::show - \Github\Api\Organization\Teams::update - \Github\Api\Organization\Teams::remove - \Github\Api\Organization\Teams::members - \Github\Api\Organization\Teams::check - \Github\Api\Organization\Teams::addMember - \Github\Api\Organization\Teams::removeMember
Contributor
Author
Contributor
we could add the organization as a optional argument, and also adjust the implementation to be BC compatibel, e.g. instead of use |
GrahamCampbell
suggested changes
Apr 14, 2020
Contributor
|
Don't worry about StyleCI. Its fixes will be automatically applied when the PR is merged (assuming the package author has enabled that option). |
Contributor
Author
|
@staabm I've changed it to your suggested way but keep in mind that in a next version, the $organization should be set as required since the api calls don't work without an organization set. |
acrobat
requested changes
Apr 15, 2020
acrobat
approved these changes
Apr 20, 2020
Collaborator
|
Thanks @lolos! And congrats on your first contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the API calls for the functions:
based on the official Github's v3 API documentation:
since those functions incorrectly threw
Github\Exception\RuntimeException: Not Found