Deployments: use proper media-type for in_progress/queued, inactive state#979
Merged
Conversation
staabm
changed the title
acrobat
approved these changes
Mar 25, 2021
Collaborator
|
Thank you @staabm |
Contributor
Author
|
Thx for merging @acrobat . Could this change also be merged into the 2.x branch? |
Collaborator
|
Yes, this is a bugfix that could be backported! Can you create a PR for 2.x? Thanks! |
clxmstaab
pushed a commit
to clxmstaab/php-github-api
that referenced
this pull request
Mar 26, 2021
…eued, inactive state (staabm) This PR was squashed before being merged into the 3.1.x-dev branch. Discussion ---------- closes KnpLabs#978 Commits ------- 5ffefdc Deployments: use correct media-type for in_progress/queued, inactive bf3eb1f Update Deployment.php ca128f6 cs
Contributor
here we go #981 |
acrobat
added a commit
that referenced
this pull request
Mar 27, 2021
This PR was merged into the 2.x branch. Discussion ---------- Deployments: use proper media-type for in_progress/queued, inactive state as discussed in #979 (comment) Commits ------- 0c2815f bug #979 Deployments: use proper media-type for in_progress/queued, inactive state (staabm)
acrobat
added a commit
that referenced
this pull request
Mar 27, 2021
* 2.x: bug #979 Deployments: use proper media-type for in_progress/queued, inactive state (staabm) Update changelog for 2.19.1 release
Contributor
|
@acrobat could we also get a new 3.x release? some bugfixes - like the one in this PR - are not yet part of a 3.x release, but are fixed on the latest 2.x releases |
Collaborator
|
@clxmstaab I will tag a new 3.x release today! |
Collaborator
|
@clxmstaab 3.2.0 is released! |
Contributor
|
thank you so much <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #978