Deployments: added missing 'delete deployment' endpoint - #991
Merged
Conversation
Contributor
|
Test incoming |
acrobat
requested changes
Apr 4, 2021
acrobat
left a comment
acrobat
left a comment
Collaborator
There was a problem hiding this comment.
Can you add a docs entry for this endpoint? Otherwise the pr is good to go!
acrobat
pushed a commit
that referenced
this pull request
Apr 4, 2021
…bat) This PR was squashed before being merged into the 2.x branch. Discussion ---------- fixes ``` Warning: Illegal string offset 'code' in GithubExceptionThrower.php on line 59 ``` when deleting a deployment which is not yet set to inactive, see #991 I guess the warning beeing fixed is not explicitly related to the new endpoint added in #991 but I experienced it in this case. Commits ------- 2afb40c fixed php warning in GithubExceptionThrower 2b35311 added testcase a54c223 Update lib/Github/HttpClient/Plugin/GithubExceptionThrower.php e000f00 Update GithubExceptionThrower.php 0e0265f fix CS 1ae94ab Improve single message errors and testcase
Contributor
Author
|
docs added |
clxmstaab
commented
Apr 6, 2021
acrobat
requested changes
Apr 6, 2021
acrobat
approved these changes
Apr 7, 2021
Collaborator
|
Thank you @clxmstaab |
acrobat
added a commit
that referenced
this pull request
Apr 7, 2021
* 2.x: Bump 2.x branch alias feature #991 Deployments: added missing 'delete deployment' endpoint (clxmstaab)
Contributor
|
@acrobat thx for merging. do you have plans for a new release ? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this api endpoint was missing completely from the client. this is the only missing feature in 2.x for me, so it would be really cool this could be merged into 2.x.
my php constraints do not allow me to update to 3.x yet.
this PR added the endpoint as described in https://docs.github.com/en/rest/reference/repos#delete-a-deployment