Revert memory leak change from 0.11.0

Caused many issues, though in principle the idea seems sound. Needs further investigation and a more robust implementation.

Author: michaelbromley

src/directives/pagination/dirPagination.js

@@ -68,9 +68,12 @@
                 // Now that we have access to the `scope` we can interpolate any expression given in the paginationId attribute and
                 // potentially register a new ID if it evaluates to a different value than the rawId.
                 var paginationId = $parse(attrs.paginationId)(scope) || attrs.paginationId || DEFAULT_ID;
+                
+                // (TODO: this seems sound, but I'm reverting as many bug reports followed it's introduction in 0.11.0.
+                // Needs more investigation.)
                 // In case rawId != paginationId we deregister using rawId for the sake of general cleanliness
                 // before registering using paginationId
-                paginationService.deregisterInstance(rawId);
+                // paginationService.deregisterInstance(rawId);
                 paginationService.registerInstance(paginationId);
 
                 var repeatExpression = getRepeatExpression(expression, paginationId);
@@ -105,12 +108,14 @@
 
                 // Delegate to the link function returned by the new compilation of the ng-repeat
                 compiled(scope);
-                    
+                 
+                // (TODO: Reverting this due to many bug reports in v 0.11.0. Needs investigation as the
+                // principle is sound)
                 // When the scope is destroyed, we make sure to remove the reference to it in paginationService
                 // so that it can be properly garbage collected
-                scope.$on('$destroy', function destroyDirPagination() {
-                    paginationService.deregisterInstance(paginationId);
-                });
+                // scope.$on('$destroy', function destroyDirPagination() {
+                //     paginationService.deregisterInstance(paginationId);
+                // });
             };
         }
 

src/directives/pagination/dirPagination.spec.js

@@ -1133,7 +1133,7 @@ describe('dirPagination directive', function() {
             compile();
 
             var $list1 = containingElement.find('ul.list').eq(0);
-            var $list2 = containingElement.find('ul.list').eq(1);
+            var $list2 = containingElement.find('ul.list').eq(1); 
 
             expect(getListItems($list1)).toEqual([ '1', '2', '3' ]);
             expect(getListItems($list2)).toEqual([ 'a', 'b', 'c' ]);