Skip to content

Add filesystem audit events for Panorama Public symlinks#361

Merged
vagisha merged 3 commits into
release23.7-SNAPSHOTfrom
23.7_fb_add-filesystem-audit-events
Jul 13, 2023
Merged

Add filesystem audit events for Panorama Public symlinks#361
vagisha merged 3 commits into
release23.7-SNAPSHOTfrom
23.7_fb_add-filesystem-audit-events

Conversation

@vagisha
Copy link
Copy Markdown
Collaborator

@vagisha vagisha commented Jul 6, 2023

Rationale

We would like to add filesystem audit events:

  • When a file is moved from the submitted folder to the copy on Panorama Public, and a symlink is created in the submitted folder.
  • When the target of a symlink in the submitted folder is moved from the previous copy on Panorama Public to a new copy
    • add an event in the previous copy that the file has been moved, and replaced with a symlink
    • add an event in the submitted folder that the symlink target has been updated.
  • When a Panorama Public copy is deleted, add events in the submitted folder for each symlink that is replaced with the target file from the Panorama Public copy.

Related Pull Requests

Changes

  • added filesystem events
  • added additional logging
  • removed unused boolean parameter createSourceSymLinks in PanoramaPublicSymlinkManager.moveAndSymLinkDirectory()

…or replaced with the target file.

- Added additional logging, and removed unused boolean parameter from moveAndSymLinkDirectory.
- Use ContainerManager.getForPath(org.labkey.api.util.Path) to get the container corresponding to a file path.
Copy link
Copy Markdown
Contributor

@labkey-martyp labkey-martyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @vagisha I've been out on vacation. I did not test this but I don't see any issues in the code. Let us know if you need any testing.

@vagisha vagisha merged commit 1bd3975 into release23.7-SNAPSHOT Jul 13, 2023
@vagisha vagisha deleted the 23.7_fb_add-filesystem-audit-events branch July 13, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants