Convert move entities between projects APIs to use new query-moveRows.api#1369
Merged
Conversation
… moveRows API format
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
labkey-susanh
approved these changes
Dec 14, 2023
# Conflicts: # packages/components/package-lock.json # packages/components/package.json # packages/components/releaseNotes/components.md
cnathe
added
TeamCity test review complete
and removed
needs TeamCity test review
labels
This was referenced Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
After we enabled moving of entities between projects, we knew that moving via the API would eventually be helpful. This is particularly useful since we’ve limited the number of entities that can be moved via the UI for performance purposes. We also realized after the implementation that instead of having individual controller actions for each entity type, we could consolidate them into a single MoveRowsAction in the QueryController and have the implementations for each handled within the specific QueryUpdateService for the entities table.
Related Pull Requests
Changes