From 1db5d8d9a3551682e87cea4c1e455b3e049a7b73 Mon Sep 17 00:00:00 2001 From: ankurjuneja Date: Fri, 10 Apr 2026 07:35:17 -0700 Subject: [PATCH 1/5] Fix accessibility issues suggested by WAVE --- api/webapp/clientapi/ext3/PersistentToolTip.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/webapp/clientapi/ext3/PersistentToolTip.js b/api/webapp/clientapi/ext3/PersistentToolTip.js index a65026904cc..3d02731acbf 100644 --- a/api/webapp/clientapi/ext3/PersistentToolTip.js +++ b/api/webapp/clientapi/ext3/PersistentToolTip.js @@ -167,7 +167,7 @@ LABKEY.ext.CalloutTip = Ext.extend(LABKEY.ext.PersistentToolTip, { if (!this.targetAutoEl) { this.targetAutoEl = '' + - '' + + 'Show details' + ''; } From 86e1f1237a34fb9332d31380bfe27ee5d394c86b Mon Sep 17 00:00:00 2001 From: ankurjuneja Date: Fri, 10 Apr 2026 07:59:51 -0700 Subject: [PATCH 2/5] Add alt tags to the - icon and dropdown icons in the grid --- api/src/org/labkey/api/query/AbstractNestableDataRegion.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/api/src/org/labkey/api/query/AbstractNestableDataRegion.java b/api/src/org/labkey/api/query/AbstractNestableDataRegion.java index 2392710f88f..00b29cf5acb 100644 --- a/api/src/org/labkey/api/query/AbstractNestableDataRegion.java +++ b/api/src/org/labkey/api/query/AbstractNestableDataRegion.java @@ -38,6 +38,7 @@ import static org.labkey.api.util.DOM.A; import static org.labkey.api.util.DOM.Attribute.align; +import static org.labkey.api.util.DOM.Attribute.alt; import static org.labkey.api.util.DOM.Attribute.colspan; import static org.labkey.api.util.DOM.Attribute.id; import static org.labkey.api.util.DOM.Attribute.src; @@ -94,7 +95,8 @@ protected void renderExtraRecordSelectorContent(RenderContext ctx, HtmlWriter ou at( id, getName() + "-Handle" + value, valign, "middle", - src, ctx.getViewContext().getContextPath() + "/_images/" + (_expanded ? "minus" : "plus") + ".gif" + src, ctx.getViewContext().getContextPath() + "/_images/" + (_expanded ? "minus" : "plus") + ".gif", + alt, _expanded ? "Collapse row" : "Expand row" ) ) ).appendTo(out); From d87096a30a8f9e1b5101f2708d577ff9101a4d85 Mon Sep 17 00:00:00 2001 From: ankurjuneja Date: Fri, 10 Apr 2026 12:52:37 -0700 Subject: [PATCH 3/5] Add an aria label to buttons that are just an icon --- api/src/org/labkey/api/util/DOM.java | 17 +++++++++++++++++ api/src/org/labkey/api/util/LinkBuilder.java | 3 ++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/api/src/org/labkey/api/util/DOM.java b/api/src/org/labkey/api/util/DOM.java index f31179179b2..296c9b0bfc8 100644 --- a/api/src/org/labkey/api/util/DOM.java +++ b/api/src/org/labkey/api/util/DOM.java @@ -579,6 +579,23 @@ public _Attributes data(boolean condition, String datakey, Object value) } return this; } + public _Attributes aria(String ariakey, Object value) + { + if (null == expandos) + expandos = new ArrayList<>(); + expandos.add(new Pair<>("aria-" + ariakey,value)); + return this; + } + public _Attributes aria(boolean condition, String ariakey, Object value) + { + if (condition) + { + if (null == expandos) + expandos = new ArrayList<>(); + expandos.add(new Pair<>("aria-" + ariakey,value)); + } + return this; + } public _Attributes cl(String...names) { diff --git a/api/src/org/labkey/api/util/LinkBuilder.java b/api/src/org/labkey/api/util/LinkBuilder.java index 13c5ff67262..fde40f659b8 100644 --- a/api/src/org/labkey/api/util/LinkBuilder.java +++ b/api/src/org/labkey/api/util/LinkBuilder.java @@ -155,7 +155,8 @@ public Appendable appendTo(Appendable out) .at(!lb.enabled, disabled, true) .data(null != lb.tooltip, "tt", "tooltip") .data(null != lb.tooltip, "placement","top") - .data(null != lb.tooltip, "original-title", lb.tooltip), + .data(null != lb.tooltip, "original-title", lb.tooltip) + .aria(lb.iconCls != null && lb.tooltip != null, "label", lb.tooltip), (lb.iconCls != null ? null : lb.html) ).appendTo(out); } From 2ecd5ba69e0a644fb55672101c53498eecae255e Mon Sep 17 00:00:00 2001 From: ankurjuneja Date: Wed, 22 Apr 2026 10:23:34 -0700 Subject: [PATCH 4/5] update themes package to 1.9.0 --- core/package-lock.json | 2 +- core/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/package-lock.json b/core/package-lock.json index 44be569616f..c15831997f8 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -9,7 +9,7 @@ "version": "0.0.0", "dependencies": { "@labkey/components": "7.29.3", - "@labkey/themes": "1.8.0" + "@labkey/themes": "1.9.0" }, "devDependencies": { "@labkey/build": "9.1.0", diff --git a/core/package.json b/core/package.json index c6fe4ec8cfb..3840dc7894e 100644 --- a/core/package.json +++ b/core/package.json @@ -54,7 +54,7 @@ }, "dependencies": { "@labkey/components": "7.29.3", - "@labkey/themes": "1.8.0" + "@labkey/themes": "1.9.0" }, "devDependencies": { "@labkey/build": "9.1.0", From c48c2a46151db143b7c08bcb650dc11dc9ee4ef0 Mon Sep 17 00:00:00 2001 From: cnathe Date: Wed, 22 Apr 2026 17:04:15 -0500 Subject: [PATCH 5/5] update @labkey/themes version --- core/package-lock.json | 8 ++++---- core/package.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/core/package-lock.json b/core/package-lock.json index b780fa5c2e3..a9cfc961f64 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -9,7 +9,7 @@ "version": "0.0.0", "dependencies": { "@labkey/components": "7.31.1", - "@labkey/themes": "1.8.0" + "@labkey/themes": "1.9.0" }, "devDependencies": { "@labkey/build": "9.1.1", @@ -3825,9 +3825,9 @@ } }, "node_modules/@labkey/themes": { - "version": "1.8.0", - "resolved": "https://labkey.jfrog.io/artifactory/api/npm/libs-client/@labkey/themes/-/@labkey/themes-1.8.0.tgz", - "integrity": "sha512-e/UgJ+Pd7+kuscsm0IJFkPH07SLcPKcHA1jfGRSdjGKYSMc6QRcBgE1/6ETAnly+39QKRukR3lNmC0w5KW/M/g==", + "version": "1.9.0", + "resolved": "https://labkey.jfrog.io/artifactory/api/npm/libs-client/@labkey/themes/-/@labkey/themes-1.9.0.tgz", + "integrity": "sha512-ecwSkBAcI4NqspsFCSiS1dRXh/lAtb/hHg4jyca1jl8JVosnpNfZI/XW99UTF4pwwKlVu6cDvxGeKErOJxVkvg==", "hasInstallScript": true, "license": "SEE LICENSE IN LICENSE.txt" }, diff --git a/core/package.json b/core/package.json index cf17dea5062..b494f26d13f 100644 --- a/core/package.json +++ b/core/package.json @@ -54,7 +54,7 @@ }, "dependencies": { "@labkey/components": "7.31.1", - "@labkey/themes": "1.8.0" + "@labkey/themes": "1.9.0" }, "devDependencies": { "@labkey/build": "9.1.1",