Skip to content

Set ExpRun's filePathRoot to be the container's file root#723

Closed
vagisha wants to merge 1 commit into
release23.3-SNAPSHOTfrom
23.3_fb_exprun-filePathRoot
Closed

Set ExpRun's filePathRoot to be the container's file root#723
vagisha wants to merge 1 commit into
release23.3-SNAPSHOTfrom
23.3_fb_exprun-filePathRoot

Conversation

@vagisha
Copy link
Copy Markdown
Collaborator

@vagisha vagisha commented May 20, 2023

Rationale

Skyline documents are typically uploaded and imported from the container's file root when the import is driven by Skyline. However, it is possible to manually upload and import documents from a subfolder of the container's file root. When these runs are exported as part of folder export, the exported directory path does not include the subfolder. For example, for a run imported from @files/SkylineFiles the contents of the export folder look like this:

Run202
  |-- skyline_docr.sky.zip
  |-- skyline_doc

This does not include the SkylineFiles subfolder, and makes it difficult to adjust the dataFileUrls on ExpData in the folder import part of the Panorama Public pipeline. Setting ExpRun's filePathRoot to always be the container's file root will ensure that the exported run files are at the same relative path as they are in the source container:

Run202
  |-- SkylineFiles
        |-- skyline_doc.sky.zip
        |-- skyline_doc

Related Pull Requests

@vagisha
Copy link
Copy Markdown
Collaborator Author

vagisha commented May 22, 2023

Replaced with #724

@vagisha vagisha closed this May 22, 2023
@vagisha vagisha deleted the 23.3_fb_exprun-filePathRoot branch May 22, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant