diff --git a/src/org/labkey/test/LabKeySiteWrapper.java b/src/org/labkey/test/LabKeySiteWrapper.java index 112757f4c0..8483699931 100644 --- a/src/org/labkey/test/LabKeySiteWrapper.java +++ b/src/org/labkey/test/LabKeySiteWrapper.java @@ -404,7 +404,7 @@ public void attemptSignIn(String email, String password) assertElementPresent(Locator.tagWithName("form", "login")); setFormElement(Locator.id("email"), email); setFormElement(Locator.id("password"), password); - WebElement signInButton = Locator.lkButton("Sign In").findElement(getDriver()); + WebElement signInButton = Locator.button("Sign In").findElement(getDriver()); doAndMaybeWaitForPageToLoad(10_000, () -> { signInButton.click(); shortWait().until(ExpectedConditions.invisibilityOfElementLocated(Locator.byClass("signing-in-msg"))); diff --git a/src/org/labkey/test/components/react/BaseReactSelect.java b/src/org/labkey/test/components/react/BaseReactSelect.java index 57b05c4a24..3f72cb9fa7 100644 --- a/src/org/labkey/test/components/react/BaseReactSelect.java +++ b/src/org/labkey/test/components/react/BaseReactSelect.java @@ -612,21 +612,16 @@ public BaseReactSelectFinder withLabelwithSpan(String labelSpanText) + /* use this to find a reactSelect when the label text is contained within a span/span*/ + public BaseReactSelectFinder followingLabelWithSpan(String labelText) - { - _locator = Locators.containerWithDescendant(Locator.tag("label").withChild(Locator.tagWithText("span", labelText))); + _locator = Locators.containerWithDescendant(Locator.tagWithClassContaining("span", "control-label").withDescendant(Locator.tag("span").withText(spanText))); return this; } - public BaseReactSelectFinder followingSpanWithClass(String cls) { - _locator = Locators.containerWithDescendant(Locator.tagWithClass("label", cls)); + _locator = Locators.containerWithDescendant(Locator.tagWithClass("span", cls)); return this; } @@ -647,7 +642,7 @@ public BaseReactSelectFinder withinFormGroupSkipSelect(String labelText) { _locator = Locator.tagWithClass("div", "form-group") - .withChild(Locator.tag("label").withChild(Locator.tagWithText("span", labelText))); + .withChild(Locator.byClass("control-label").withChild(Locator.tagWithText("span", labelText))); return this; } diff --git a/src/org/labkey/test/components/ui/entities/EntityBulkDialog.java b/src/org/labkey/test/components/ui/entities/EntityBulkDialog.java index ba23e4e2d0..47ab69ad39 100644 --- a/src/org/labkey/test/components/ui/entities/EntityBulkDialog.java +++ b/src/org/labkey/test/components/ui/entities/EntityBulkDialog.java @@ -175,12 +175,12 @@ protected abstract class ElementCache extends ModalDialog.ElementCache */ public abstract WebElement formRow(CharSequence fieldIdentifier); - // For composite fields (e.g. StoredAmount + Units) that render a
label instead of