Adding pluggable ID generation see #497#858
Closed
martinthomson wants to merge 1 commit intosocketio:masterfrom
Closed
Adding pluggable ID generation see #497#858martinthomson wants to merge 1 commit intosocketio:masterfrom
martinthomson wants to merge 1 commit intosocketio:masterfrom
Conversation
Contributor
|
It doesn't apply cleanly |
Contributor
Author
|
My sincerest apologies for the apply failure. Put that down to me being a complete git (novice). I've managed to bludgeon git into submission and (pending unmerged changes) this should apply cleanly now. |
|
Is this something that will be integrated soonish? Definitely something that would help reduce the additional mappings I have to maintain. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want control over session IDs (see #497), but I don't need to give that control to the client. This enables both options.
In my example, I am embedding application state in the session ID so that I can forward messages to back end processing without maintaining additional mappings.
I've also added the ability to get the handshake data through to the ID generator and for the authorize method to add to or override the handshake data. This was obviously intended originally, but never quite connected up (repeated use of ``newData || handshakeData''). This handshake data can be seen by the ID generator as well in order to advise in its processing.
A few more tests added to cover these capabilities.