Skip to content

Commit a2c3774

Browse files
authored
fix(Player): Store the full library version in cache entries (#1032)
1 parent dee2b07 commit a2c3774

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/core/Player.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ interface SerializablePlayer {
1919
sts: number;
2020
sig_sc?: string;
2121
nsig_sc?: string;
22-
library_version: number;
22+
library_version: string;
2323
}
2424

2525
/**
@@ -200,10 +200,9 @@ export default class Player {
200200
return null;
201201

202202
try {
203-
const current_library_version = parseInt(packageInfo.version.split('.', 1)[0]);
204203
const player_data = BinarySerializer.deserialize<SerializablePlayer>(new Uint8Array(buffer));
205204

206-
if (player_data.library_version !== current_library_version) {
205+
if (player_data.library_version !== packageInfo.version) {
207206
Log.warn(TAG, `Cached player data is from a different library version (${player_data.library_version}). Ignoring it.`);
208207
return null;
209208
}
@@ -225,14 +224,12 @@ export default class Player {
225224
if (!cache || !this.sig_sc || !this.nsig_sc)
226225
return;
227226

228-
const current_library_version = parseInt(packageInfo.version.split('.', 1)[0]);
229-
230227
const buffer = BinarySerializer.serialize({
231228
player_id: this.player_id,
232229
sts: this.sts,
233230
sig_sc: this.sig_sc,
234231
nsig_sc: this.nsig_sc,
235-
library_version: current_library_version
232+
library_version: packageInfo.version
236233
});
237234

238235
await cache.set(this.player_id, buffer);

0 commit comments

Comments
 (0)