feat: Add support for descriptive audio tracks#338
Merged
LuanRT merged 1 commit intoLuanRT:mainfrom Mar 8, 2023
Merged
Conversation
Owner
|
Nice, I had no idea YouTube supported these. Very interesting. Will test & review this PR today. Thanks! Edit: |
LuanRT
approved these changes
Mar 8, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Turns out that YouTube also supports descriptive audio tracks not just dubs (courtesy of TeamNewPipe/NewPipeExtractor#1026)
This pull request adds a new field to the Format class
is_descriptiveand also refactors the DASH manifest code to support descriptive audio tracks. Previously in #308 I did the grouping based on the language, now that we know that it's not the only differentiating factor between audio tracks, I decided to group them based on the audio track id that YouTube provides. That also makes it easier to add support for additonal audio track types in the future, if we find out there are more.Example video: https://www.youtube.com/watch?v=TjxC-evzxdk
Type of change
Checklist: