Skip to content

fix(Search): Return search results even if there are ads#373

Merged
LuanRT merged 1 commit intoLuanRT:mainfrom
absidue:fix-empty-search
Mar 27, 2023
Merged

fix(Search): Return search results even if there are ads#373
LuanRT merged 1 commit intoLuanRT:mainfrom
absidue:fix-empty-search

Conversation

@absidue
Copy link
Collaborator

@absidue absidue commented Mar 26, 2023

Description

Currently YouTube.js always counts the first item section in the search response as the results, sometimes however the first item section contains ads, which means that YouTube.js doesn't return any search results. This pull request tries to find the first item section that has items.

Searching for "Marques Brownlee" with the type filter set to all, videos or channels, should make this bug show up (usually it appears for at least one of the three cases).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@LuanRT LuanRT merged commit 2c5907f into LuanRT:main Mar 27, 2023
@absidue absidue deleted the fix-empty-search branch March 27, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants