fix(Search): Return search results even if there are ads#373
Merged
LuanRT merged 1 commit intoLuanRT:mainfrom Mar 27, 2023
Merged
fix(Search): Return search results even if there are ads#373LuanRT merged 1 commit intoLuanRT:mainfrom
LuanRT merged 1 commit intoLuanRT:mainfrom
Conversation
LuanRT
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently YouTube.js always counts the first item section in the search response as the results, sometimes however the first item section contains ads, which means that YouTube.js doesn't return any search results. This pull request tries to find the first item section that has items.
Searching for "Marques Brownlee" with the type filter set to all, videos or channels, should make this bug show up (usually it appears for at least one of the three cases).
Type of change
Checklist: