fix(VideoInfo): Use microformat view_count when videoDetails view_count is NaN#393
Merged
LuanRT merged 1 commit intoLuanRT:mainfrom Apr 30, 2023
Merged
fix(VideoInfo): Use microformat view_count when videoDetails view_count is NaN#393LuanRT merged 1 commit intoLuanRT:mainfrom
LuanRT merged 1 commit intoLuanRT:mainfrom
Conversation
1 task
Owner
|
I think this happens because of the shorts params. If you manually send a request with the |
LuanRT
approved these changes
Apr 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like YouTube removed the view count from the video details, as I'm not sure if it's just on my machine or for everyone, it still tries to use the view count from the video details first before falling back to the microformat one. I wonder if this didn't show up earlier because we were using a hardcoded visitor ID?