add feature tests

Author: michalpodlecki

cider-ci/specs_job-context.yml

@@ -2,7 +2,7 @@ generate_tasks:
   # all of them
   include_match: spec\/.*_spec.rb
   # only request specs
-  include_match: spec\/requests\/.*_spec.rb
+  # include_match: spec\/requests\/.*_spec.rb
   # focus on one
   # include_match: spec.*dashboard_spec.rb
 

spec/config/browser.rb

@@ -9,6 +9,10 @@ def set_capybara_values
   Capybara.server_port = port
 end
 
+def maximize_window_if_possible
+  Capybara.page.driver.browser.manage.window.maximize if Capybara.current_driver == :firefox
+end
+
 ACCEPTED_FIREFOX_ENV_PATHS = ['FIREFOX_ESR_78_PATH']
 
 def accepted_firefox_path
@@ -33,7 +37,12 @@ def accepted_firefox_path
   # profile["intl.accept_languages"] = "en"
   #
   profile_config = {
-    'browser.helperApps.neverAsk.saveToDisk' => 'image/jpeg,application/pdf,application/json',
+    'browser.helperApps.neverAsk.saveToDisk' => %w(
+      image/jpeg
+      application/pdf
+      application/json
+      text/plain
+    ).join(','),
     'browser.download.folderList' => 2, # custom location
     'browser.download.dir' => BROWSER_DOWNLOAD_DIR.to_s
   }
@@ -71,6 +80,7 @@ def accepted_firefox_path
 
   config.before :all do
     set_capybara_values
+    maximize_window_if_possible
   end
 
   config.before :each do |example|

spec/config/session_helper.rb

@@ -0,0 +1,22 @@
+module Config
+  module SessionHelper
+    def sign_in
+      visit "/"
+
+      expect(page).to have_content "You are not signed in!"
+
+      set_cookie
+    end
+
+    def session_cookie_value
+      MadekOpenSession.build_session_value(user) if user
+    end
+
+    def set_cookie
+      Capybara.current_session.driver.browser.manage.add_cookie(
+        name: "madek-session",
+        value: session_cookie_value
+      )
+    end
+  end
+end

spec/factories/media_store.rb

@@ -6,8 +6,13 @@
     type { MediaStore::TYPES.without("database").sample }
 
     trait :database do
-      id { "database" }
-      type { "database" }
+      id "database"
+      type "database"
+    end
+
+    trait :filesystem do
+      id "legacy-file-store"
+      type "filesystem"
     end
 
     trait :with_users do

spec/features/dashboard_spec.rb

@@ -1,19 +1,46 @@
-require 'spec_helper'
-require 'pry'
-
-describe "displaying dashboard", type: :feature do
-  before do
-    visit "/"
-    # TODO there is something missing here
-    user = User.find_by(login: 'adam')
-    expect(user).to be
-    cookie_value = MadekOpenSession.build_session_value(user)
-    page.driver.browser.manage.add_cookie(name: "madek-session", value: cookie_value)
+require "features/shared/authentication_error"
+
+describe "Dashboard", type: :feature do
+  let(:user) { create(:user, :with_system_admin_role) }
+  let(:username) do
+    person = user.person
+    "#{person.first_name} #{person.last_name}"
+  end
+  let(:path) { "/media-service" }
+
+  context "for public access" do
+    before do
+      visit path
+    end
+
+    it "doesn't display user's dropdown in navbar" do
+      expect(page).not_to have_css(".navbar a.dropdown-toggle")
+    end
+
+    it_displays "authentication error"
   end
 
-  it "displays it ;)" do
-    visit '/media-service/'
+  context "for signed in user" do
+    before do
+      sign_in
+      visit path
+    end
+
+    it "displays user's dropdown" do
+      expect(page).to have_css(".navbar a.dropdown-toggle", text: username)
+    end
+  end
+end
+
+def expect_dashboard_data
+  within ".top-resources" do
+    expect(page).to have_link("Media-Stores", href: "/media-service/stores/")
+    expect(page).to have_link("Settings", href: "/media-service/settings/")
+    expect(page).to have_link("Uploads", href: "/media-service/uploads/")
+  end
 
-    expect(page).to have_css('.navbar', text: 'Adam Admin')
+  within ".dev-and-build" do
+    expect(page).to have_link("Dependency diagram", href: "/media-service/public/deps.svg")
+    expect(page).to have_link(nil, href: "https://github.com/Madek/madek-media-service")
   end
 end

spec/features/media_stores_spec.rb

@@ -1,68 +1,75 @@
-require 'pry'
+require "features/shared/authentication_error"
+require "features/shared/authorization_error"
 
 describe "Media Stores", type: :feature do
+  let!(:database_store) { create(:media_store, :database) }
+  let!(:filesystem_store) { create(:media_store, :filesystem) }
+  let(:path) { "/media-service/stores/" }
 
-  # TODO user creation seems to be missing
-
-  let(:session_cookie_value) do
-    MadekOpenSession.build_session_value(User.find_by(login: 'adam'))
-  end
+  context "for public" do
+    before do
+      visit path
+    end
 
-  before do
-    visit "/"
-    expect(page).to have_content "You are not singed in!"
+    it "doesn't display user's dropdown in navbar" do
+      expect(page).not_to have_css('.navbar a.dropdown-toggle')
+    end
 
-    # page.driver.browser.manage.add_cookie(name: "madek-session", value: cookie_value)
-    Capybara.current_session.driver.browser.manage.add_cookie(
-      name: "madek-session",
-      value: session_cookie_value
-    )
+    it_displays "authentication error"
+    it_displays "authorization error"
   end
 
-  it "displays it ;)" do
-    visit '/media-service/'
+  context "for an ordinary user" do
+    let(:user) { create(:user) }
 
-    find('.navbar .dropdown-toggle').click
-    click_link 'Media-Stores'
+    before { sign_in }
 
-    expect(page).to have_css('h2', text: 'Media-Stores')
-
-    within '#stores-page' do
-      expect(page).to have_css('table')
-      within 'table' do
-        expect(page).to have_css('tr', text: 'legacy-file-store filesystem')
-        expect(page).to have_css('tr', text: 'database database')
-      end
-    end
+    it_displays "authorization error"
   end
 
-  it "navigates to store users page" do
-    visit "/media-service/stores/"
+  context "for an user with admin role" do
+    let(:user) { create(:user, :with_admin_role) }
 
-    click_link href: '/media-service/stores/legacy-file-store/users/'
+    before { sign_in }
 
-    expect(page).to have_css('h2', text: 'Media-Store legacy-file-store Users')
+    it_displays "authorization error"
+  end
 
-    page.assert_selector('table.users tbody tr', minimum: 5)
+  context "for an user with system admin role" do
+    let(:user) { create(:user, :with_system_admin_role) }
 
-    fill_in 'term', with: 'ada'
+    before do
+      sign_in
 
-    expect(page).to have_css('table.users tbody tr', count: 1)
+      visit path
+    end
 
-    within '.direct-priority-component' do
-      expect(page).to have_content '-'
+    it "is navigable" do
+      within first(".navbar") do
+        find(".dropdown-toggle").click
+        click_link "Media-Stores"
+      end
 
-      click_button 'Edit'
-    end
+      expect(current_path).to eq("/media-service/stores/")
+      expect(page).to have_css("h2", text: "Media-Stores")
 
-    expect(page).to have_css('.modal')
-    fill_in 'direct_priority', with: 5
+      within '#stores-page' do
+        expect(page).to have_css('table')
+        within 'table' do
+          expect(page).to have_css('tr', text: 'legacy-file-store filesystem')
+          expect(page).to have_css('tr', text: 'database database')
+        end
+      end
+    end
 
-    within('.modal') { click_button 'Save' }
+    specify "page has links to users" do
+      expect(page).to have_link("0", href: "/media-service/stores/legacy-file-store/users/")      
+      expect(page).to have_link("0", href: "/media-service/stores/database/users/")      
+    end
 
-    expect(page).to have_css('table.users tbody tr', count: 1)
-    within '.combined-priority-component' do
-      expect(page).to have_content '5'
+    specify "page has links to groups" do
+      expect(page).to have_link("0", href: "/media-service/stores/legacy-file-store/groups/")      
+      expect(page).to have_link("0", href: "/media-service/stores/database/groups/")      
     end
   end
 end

spec/features/originals_spec.rb

@@ -0,0 +1,80 @@
+require "features/shared/authentication_error"
+
+shared_examples "media file details" do
+  it "displays View link" do
+    expect(page)
+      .to have_link("View",
+                    href: /\/media-service\/originals\/#{media_file.id}\/content\?download=false$/)
+
+    click_link "View"
+    expect(page.body).to include(file_content)
+  end
+
+  it "displays Download link" do
+    expect(page)
+      .to have_link("Download",
+                    href: /\/media-service\/originals\/#{media_file.id}\/content\?download=true$/)
+
+    expect(File).not_to exist(BROWSER_DOWNLOAD_DIR + "/small.txt")
+
+    click_link "Download"
+
+    expect(File).to exist(BROWSER_DOWNLOAD_DIR + "/small.txt")
+    expect(File.read(BROWSER_DOWNLOAD_DIR + "/small.txt")).to eq(file_content)
+  end
+
+  it "displays filename" do
+    expect(page).to have_content("Filename\n#{media_file.filename}")
+  end
+
+  it "displays file size" do
+    expect(page).to have_content "Size\n132.0B"
+  end
+end
+
+describe "Originals", type: :feature do
+  let(:path) { "/media-service/originals/#{media_file.id}" }
+  let(:file_path) { "spec/support/files/small.txt" }
+  let(:file_content) { File.read(file_path) }
+
+  before do
+    FileUtils.rm_f(BROWSER_DOWNLOAD_DIR + "/small.txt")
+  end
+
+  context "for public acccess" do
+    let(:media_file) { create(:media_file_for_image) }
+
+    it_displays "authentication error"
+  end
+
+  context "for signed in user" do
+    let(:user) { create(:user) }
+    let(:media_file) { OpenStruct.new(id: upload_file_and_return_id) }
+
+    before do
+      sign_in
+      visit path
+    end
+
+    it_displays "media file details"
+  end
+end
+
+def upload_file_and_return_id
+  create(:media_service_setting, upload_min_part_size: 100)
+  create(:media_store, :database, :with_users, users: [user])
+
+  visit "/media-service/uploads/"
+
+  within "#uploads-page .form" do
+    attach_file nil, file_path
+  end
+
+  expect(page).to have_css(".modal-body",
+                            text: /POST \/media-service\/uploads\/[a-z0-9-]+\/complete/)
+  link_to_original = find_link("Original")
+  link_to_original[:href]
+    .match(/\/media-service\/originals\/([a-z0-9-]+)$/)
+    .captures
+    .first
+end