add missing feature tests

Author: michalpodlecki

spec/features/stores/groups_spec.rb

@@ -0,0 +1,152 @@
+require "features/shared/authentication_error"
+require "features/shared/authorization_error"
+
+describe "Groups", type: :feature do
+  let!(:store) { create(:media_store, :database) }
+  let(:path) { "/media-service/stores/database/groups/" }
+
+  context "for public" do
+    before do
+      visit path
+    end
+
+    it "doesn't display user's dropdown in navbar" do
+      expect(page).not_to have_css('.navbar a.dropdown-toggle')
+    end
+
+    it_displays "authentication error"
+    it_displays "authorization error"
+  end
+
+  context "for an ordinary user" do
+    let(:user) { create(:user) }
+
+    before { sign_in }
+
+    it_displays "authorization error"
+  end
+
+  context "for an user with admin role" do
+    let(:user) { create(:user, :with_admin_role) }
+
+    before { sign_in }
+
+    it_displays "authorization error"
+  end
+
+  context "for an user with system admin role" do
+    let(:user) { create(:user, :with_system_admin_role) }
+    let!(:group_1) { create(:group, name: "Empty group") }
+    let!(:group_2) { create(:group, :with_user, name: "Masters") }
+    let!(:group_3) { create(:group, name: "Family") }
+    let!(:institutional_group) do
+      create(:institutional_group,
+              name: "Foo Institutional Group",
+              institutional_name: "FOO.InstitutionalGroup")
+    end
+
+    before do
+      group_3.users << create_list(:user, 3)
+      store.groups << [group_1, group_2]
+    end
+
+    before do
+      sign_in
+
+      visit path
+    end
+
+    describe "listing" do
+      it "displays header" do
+        expect(page).to have_css("h2", text: "Media-Store database Groups")
+      end
+
+      it "displays table with groups" do
+        expect(page).to have_css("table.groups tbody tr", count: 4)
+
+        expect_order(group_1, group_3, institutional_group, group_2)
+
+        expect_row(group_1, priority: 0, users_count: 0)
+        expect_row(group_3, priority: "-", users_count: 3)
+        expect_row(institutional_group, priority: "-", users_count: 0)
+        expect_row(group_2, priority: 0, users_count: 1)
+      end
+
+      describe "filtering by user" do
+        let(:path) { "/media-service/stores/database/groups/?including-user=#{user.id}" }
+
+        before do
+          group_1.users << user
+          institutional_group.users << user
+        end
+
+        it "filters groups out" do
+          expect(page).to have_css("table.groups tbody tr", count: 2)
+
+          expect_order(group_1, institutional_group)
+
+          expect_row(group_1, priority: 0, users_count: 1)
+          expect_row(institutional_group, priority: "-", users_count: 1)
+        end
+      end
+    end
+
+    describe "groups's priority" do
+      it "is editable" do
+        expect_row(group_1, priority: 0, users_count: 0)
+        expect(page).not_to have_css(".modal")
+
+        within "tr[data-id='#{group_1.id}'] .priority-component" do
+          click_button "Edit"
+        end
+
+        within ".modal" do
+          fill_in "priority", with: 5
+          click_button "Save"
+        end
+
+        expect_row(group_1, priority: 5, users_count: 0)
+        expect(page).not_to have_css(".modal")
+      end
+
+      it "is deletable" do
+        expect(page).not_to have_css(".modal")
+
+        within "tr[data-id='#{group_3.id}'] .priority-component" do
+          click_button "Edit"
+        end
+        within ".modal" do
+          fill_in "priority", with: 3
+          click_button "Save"
+        end
+
+        within "tr[data-id='#{group_3.id}'] .priority-component" do
+          click_button "Edit"
+        end
+        within ".modal" do
+          fill_in "priority", with: ""
+          click_button "Save"
+        end
+
+        expect_row(group_3, priority: "-", users_count: 3)
+        expect(page).not_to have_css(".modal")
+      end
+    end
+  end
+end
+
+def collect_data_ids
+  all("tr[data-id]").map { |tr| tr[:"data-id"] }
+end
+
+def expect_order(*groups)
+  expect(collect_data_ids).to eq(groups.map(&:id))
+end
+
+def expect_row(group, priority:, users_count:)
+  within "tr[data-id='#{group.id}']" do
+    expect(page).to have_content(group.name)
+    expect(page).to have_css(".priority-component", text: priority)
+    expect(page).to have_css(".users-count", text: users_count)
+  end
+end

spec/features/stores/users_spec.rb

@@ -69,6 +69,17 @@
             expect(page).to have_content "Liana Warner (liana@example.com)"
           end
         end
+
+        specify "resetting filters" do
+          fill_in "term", with: "arn"
+
+          expect(page).to have_css("table.users tbody tr", count: 2)
+
+          click_link "reset-query-params"
+
+          expect(page).to have_css("table.users tbody tr", count: 4)
+          expect(page).to have_field("term", with: "")
+        end
       end
     end
 
@@ -77,14 +88,7 @@
         expect(page).to have_css(".direct-priority-component", text: "-", count: 4)
         expect(page).to have_css(".combined-priority-component", text: "-", count: 4)
 
-        within "tr[data-id='#{user.id}'] .direct-priority-component" do
-          click_button "Edit"
-        end
-
-        expect(page).to have_css(".modal")
-        fill_in "direct_priority", with: 5
-
-        within(".modal") { click_button "Save" }
+        set_direct_priority_of(user, to: 5)
 
         expect(page).to have_css('table.users tbody tr', count: 4)
         within "tr[data-id='#{user.id}'] .combined-priority-component" do
@@ -93,29 +97,94 @@
       end
 
       it "is deletable" do
+        set_direct_priority_of(user_2, to: 3)
+        set_direct_priority_of(user_2, to: "")
+
         within "tr[data-id='#{user_2.id}'] .direct-priority-component" do
-          click_button "Edit"
+          expect(page).to have_content "-"
         end
-        within ".modal" do
-          fill_in "direct_priority", with: 3
-          click_button "Save"
+        within "tr[data-id='#{user_2.id}'] .combined-priority-component" do
+          expect(page).to have_content "-"
         end
+      end
+    end
 
-        within "tr[data-id='#{user_2.id}'] .direct-priority-component" do
-          click_button "Edit"
+    describe "managing" do
+      it "navigates to groups page" do
+        within "table.users tbody tr[data-id='#{user_2.id}']" do
+          click_link "Manage"
+
+          expect(page).to have_current_path(
+            "/media-service/stores/database/groups/?including-user=#{user_2.id}"
+          )
         end
-        within ".modal" do
-          fill_in "direct_priority", with: ""
-          click_button "Save"
+      end
+    end
+
+    describe "user's combined priority" do
+      context "when user belongs to a group" do
+        let!(:group) { create(:group) }
+
+        before do
+          group.users << user
+
+          set_direct_priority_of(user, to: 4)
         end
 
-        within "tr[data-id='#{user_2.id}'] .direct-priority-component" do
-          expect(page).to have_content "-"
+        context "and group's priority value is higher" do
+          it "display correct combined priority" do
+            within "tr[data-id='#{user.id}'" do
+              click_link "Manage"
+            end
+            within("tr[data-id='#{group.id}']") { click_button "Edit" }
+            within ".modal" do
+              fill_in "priority", with: 5
+              click_button "Save"
+            end
+
+            visit path
+
+            within "tr[data-id='#{user.id}']" do
+              expect(page).to have_css(".combined-priority-component", text: 5)
+              expect(page).to have_css(".direct-priority-component", text: 4)
+              expect(page).to have_css(".groups-priority-component", text: 5)
+            end
+          end
         end
-        within "tr[data-id='#{user_2.id}'] .combined-priority-component" do
-          expect(page).to have_content "-"
+
+        context "and group's priority value is lower" do
+          it "display correct combined priority" do
+            within "tr[data-id='#{user.id}'" do
+              click_link "Manage"
+            end
+            within("tr[data-id='#{group.id}']") { click_button "Edit" }
+            within ".modal" do
+              fill_in "priority", with: 3
+              click_button "Save"
+            end
+
+            visit path
+
+            within "tr[data-id='#{user.id}']" do
+              expect(page).to have_css(".combined-priority-component", text: 4)
+              expect(page).to have_css(".direct-priority-component", text: 4)
+              expect(page).to have_css(".groups-priority-component", text: 3)
+            end
+          end
         end
       end
     end
   end
 end
+
+def set_direct_priority_of(user, to:)
+  within "tr[data-id='#{user.id}'] .direct-priority-component" do
+    click_button "Edit"
+  end
+  within ".modal" do
+    fill_in "direct_priority", with: to
+    click_button "Save"
+  end
+
+  expect(page).not_to have_css(".modal")
+end

spec/requests/stores/groups_spec.rb

@@ -53,7 +53,7 @@
           expect(response.status).to eq(200)
         end
 
-        it "returns users for the store" do
+        it "returns groups for the store" do
           expect(parsed_body).to eq({
             groups: [
               {

src/all/madek/media_service/resources/stores/store/groups/main.cljs

@@ -93,11 +93,11 @@
     ]])
 
 (defn group-row-component [group]
-  [:tr
+  [:tr {:data-id (:key group)}
    [:td.text-monospace (:index group)]
    [:td.text-center [group-name-ident-component group]]
    [:td.text-right [priority-component group]]
-   [:td.text-right.text-monospace (:users_count group)]
+   [:td.text-right.text-monospace.users-count (:users_count group)]
    ])
 
 (defn groups-table-component [groups]

src/all/madek/media_service/resources/stores/store/users/main.cljs

@@ -102,7 +102,7 @@
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
 (defn groups-priority-component [user]
-  [:div
+  [:div.groups-priority-component
    (if-let [p (:groups_priority user)]
      [:span.text-monospace p]
      [:span "-"])