From b83694b291dac29146fc9bbbf9dc1861d01efd55 Mon Sep 17 00:00:00 2001 From: veeck Date: Mon, 16 Jan 2023 20:23:49 +0100 Subject: [PATCH 1/4] Remove broken and useless conversion call windDirection is already a string ("W" etc) --- modules/default/weather/providers/weathergov.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/default/weather/providers/weathergov.js b/modules/default/weather/providers/weathergov.js index 19ce22e313..b96c1536cd 100644 --- a/modules/default/weather/providers/weathergov.js +++ b/modules/default/weather/providers/weathergov.js @@ -179,7 +179,7 @@ WeatherProvider.register("weathergov", { } else { weather.windSpeed = forecast.windSpeed.slice(0, forecast.windSpeed.search(" ")); } - weather.windDirection = this.convertWindDirection(forecast.windDirection); + weather.windDirection = forecast.windDirection; weather.temperature = forecast.temperature; weather.tempUnits = forecast.temperatureUnit; // use the forecast isDayTime attribute to help build the weatherType label From 5ee918773fc00ff41d74f84f954dcfb6cec93616 Mon Sep 17 00:00:00 2001 From: veeck Date: Mon, 16 Jan 2023 20:24:00 +0100 Subject: [PATCH 2/4] Remove useless field --- modules/default/weather/providers/weathergov.js | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/default/weather/providers/weathergov.js b/modules/default/weather/providers/weathergov.js index b96c1536cd..17bcd88516 100644 --- a/modules/default/weather/providers/weathergov.js +++ b/modules/default/weather/providers/weathergov.js @@ -181,7 +181,6 @@ WeatherProvider.register("weathergov", { } weather.windDirection = forecast.windDirection; weather.temperature = forecast.temperature; - weather.tempUnits = forecast.temperatureUnit; // use the forecast isDayTime attribute to help build the weatherType label weather.weatherType = this.convertWeatherType(forecast.shortForecast, forecast.isDaytime); From 16a3cbfbd40189f5ffe3f3d3297f7275ae349ce0 Mon Sep 17 00:00:00 2001 From: veeck Date: Mon, 16 Jan 2023 20:24:34 +0100 Subject: [PATCH 3/4] Convert windSpeed from km/h to m/s like the new logic requires --- modules/default/weather/providers/weathergov.js | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/default/weather/providers/weathergov.js b/modules/default/weather/providers/weathergov.js index 17bcd88516..10c1ad1a19 100644 --- a/modules/default/weather/providers/weathergov.js +++ b/modules/default/weather/providers/weathergov.js @@ -179,6 +179,7 @@ WeatherProvider.register("weathergov", { } else { weather.windSpeed = forecast.windSpeed.slice(0, forecast.windSpeed.search(" ")); } + weather.windSpeed = WeatherUtils.convertWindToMs(weather.windSpeed); weather.windDirection = forecast.windDirection; weather.temperature = forecast.temperature; // use the forecast isDayTime attribute to help build the weatherType label From 53dff941a8c702b5f31a4acd19effe98cb46a98f Mon Sep 17 00:00:00 2001 From: veeck Date: Mon, 16 Jan 2023 20:25:35 +0100 Subject: [PATCH 4/4] Update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 437f75bf1b..ce90e6cd13 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ _This release is scheduled to be released on 2023-04-01._ ### Fixed - Fix wrong day labels in envcanada forecast (#2987) +- Fix weathergov provider hourly forecast (#3008) ## [2.22.0] - 2023-01-01