From b386e13c0637d95c26a91f640f13c962299ff7c1 Mon Sep 17 00:00:00 2001 From: veeck Date: Sun, 22 Jan 2023 08:44:44 +0100 Subject: [PATCH 1/2] Move callback out of async method otherwise electron calls its init functions even though the config isnt loaded yet --- js/app.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/js/app.js b/js/app.js index ae2d76f4df..7a607f019a 100644 --- a/js/app.js +++ b/js/app.js @@ -249,11 +249,12 @@ function App() { }); Log.log("Sockets connected & modules started ..."); - if (typeof callback === "function") { - callback(config); - } }); }); + + if (typeof callback === "function") { + callback(config); + } }); }; From 66ddc0915448d061a22d8a96a616b123e1b15023 Mon Sep 17 00:00:00 2001 From: veeck Date: Sun, 22 Jan 2023 09:20:19 +0100 Subject: [PATCH 2/2] Update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d7cdfd77d..77692e7d84 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,7 @@ _This release is scheduled to be released on 2023-04-01._ - Fix message display with HTML code into alert module (#2828) - Fix typo into french translation - Yr wind direction is no longer inverted +- Fix async node_helper stopping electron start (#2487) ## [2.22.0] - 2023-01-01