From c454043116e803f31494c065b34eeb692e4dadd0 Mon Sep 17 00:00:00 2001 From: Kristjan SCHMIDT <35647502+KristjanESPERANTO@users.noreply.github.com> Date: Sun, 19 Mar 2023 21:03:28 +0100 Subject: [PATCH 1/3] Add eslint rule "no-throw-literal" and fix issue --- .eslintrc.json | 1 + tests/unit/classes/translator_spec.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.eslintrc.json b/.eslintrc.json index d7684dd3f8..4e00e264c6 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -24,6 +24,7 @@ "rules": { "eqeqeq": "error", "no-prototype-builtins": "off", + "no-throw-literal": "error", "no-unused-vars": "off", "no-useless-return": "error", "prefer-template": "error" diff --git a/tests/unit/classes/translator_spec.js b/tests/unit/classes/translator_spec.js index fd6e039388..31f8fa7d26 100644 --- a/tests/unit/classes/translator_spec.js +++ b/tests/unit/classes/translator_spec.js @@ -188,7 +188,7 @@ describe("Translator", () => { const file = "translation_test.json"; XMLHttpRequest.prototype.send = () => { - throw "Shouldn't load files"; + throw new Error("Shouldn't load files"); }; Translator.translationsFallback[mmm.name] = { From 6b29679589bcd17c0ea9660966273edb3e7e3f54 Mon Sep 17 00:00:00 2001 From: Kristjan SCHMIDT <35647502+KristjanESPERANTO@users.noreply.github.com> Date: Sun, 19 Mar 2023 21:04:05 +0100 Subject: [PATCH 2/3] Update ECMAScript version --- .eslintrc.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 4e00e264c6..4460b03456 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -3,7 +3,7 @@ "plugins": ["prettier", "jsdoc", "jest"], "env": { "browser": true, - "es6": true, + "es2022": true, "jest/globals": true, "node": true }, @@ -16,7 +16,7 @@ }, "parserOptions": { "sourceType": "module", - "ecmaVersion": 2020, + "ecmaVersion": 2022, "ecmaFeatures": { "globalReturn": true } From 318153d9babf44643a00418b0520869916caef9b Mon Sep 17 00:00:00 2001 From: Kristjan SCHMIDT <35647502+KristjanESPERANTO@users.noreply.github.com> Date: Mon, 20 Mar 2023 00:45:47 +0100 Subject: [PATCH 3/3] Update Eslint --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6f94f42d63..4f06eea8b8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,6 +37,7 @@ _This release is scheduled to be released on 2023-04-01._ - Update dates in Calendar widgets every minute - Cleanup jest coverage for patches - Update `stylelint` dependencies, switch to `stylelint-config-standard` and handle `stylelint` issues +- Update Eslint config, add new rule and handle issue - Convert lots of callbacks to async/await - Fixed Open-Meteo wind speed units