From 5f5ed0b71bf4dad7ab53b833c5ae7fb565b478b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 2 Mar 2024 11:59:02 +0100 Subject: [PATCH 01/12] Create electronRebuild.yml --- .github/workflows/electronRebuild.yml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 .github/workflows/electronRebuild.yml diff --git a/.github/workflows/electronRebuild.yml b/.github/workflows/electronRebuild.yml new file mode 100644 index 0000000000..90c6782586 --- /dev/null +++ b/.github/workflows/electronRebuild.yml @@ -0,0 +1,24 @@ +name: "Electron Rebuild Testing" + +on: [pull_request] + +jobs: + rebuild: + name: Run electron-rebuild + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Install MagicMirror + run: npm run install-mm + + - name: Install @electron/rebuild + - run: npm install @electron/rebuild + + - name: Install some test library to be rebuilded + - run: npm install onoff node-pty usb + + - name: Run electron-rebuild + run: npx electron-rebuild + continue-on-error: false From 7894c55df153173e970d4025706462e026a1eff4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 2 Mar 2024 12:04:21 +0100 Subject: [PATCH 02/12] Delete .github/workflows/electronRebuild.yml --- .github/workflows/electronRebuild.yml | 24 ------------------------ 1 file changed, 24 deletions(-) delete mode 100644 .github/workflows/electronRebuild.yml diff --git a/.github/workflows/electronRebuild.yml b/.github/workflows/electronRebuild.yml deleted file mode 100644 index 90c6782586..0000000000 --- a/.github/workflows/electronRebuild.yml +++ /dev/null @@ -1,24 +0,0 @@ -name: "Electron Rebuild Testing" - -on: [pull_request] - -jobs: - rebuild: - name: Run electron-rebuild - runs-on: ubuntu-latest - steps: - - name: Checkout code - uses: actions/checkout@v4 - - - name: Install MagicMirror - run: npm run install-mm - - - name: Install @electron/rebuild - - run: npm install @electron/rebuild - - - name: Install some test library to be rebuilded - - run: npm install onoff node-pty usb - - - name: Run electron-rebuild - run: npx electron-rebuild - continue-on-error: false From d481ff573dedd2c13914f6d3c54fdbc515a399f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 2 Mar 2024 12:04:43 +0100 Subject: [PATCH 03/12] Create electronRebuild.yaml --- .github/workflows/electronRebuild.yaml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 .github/workflows/electronRebuild.yaml diff --git a/.github/workflows/electronRebuild.yaml b/.github/workflows/electronRebuild.yaml new file mode 100644 index 0000000000..90c6782586 --- /dev/null +++ b/.github/workflows/electronRebuild.yaml @@ -0,0 +1,24 @@ +name: "Electron Rebuild Testing" + +on: [pull_request] + +jobs: + rebuild: + name: Run electron-rebuild + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Install MagicMirror + run: npm run install-mm + + - name: Install @electron/rebuild + - run: npm install @electron/rebuild + + - name: Install some test library to be rebuilded + - run: npm install onoff node-pty usb + + - name: Run electron-rebuild + run: npx electron-rebuild + continue-on-error: false From ad0ffd043c12a462fa9aeed4e5897b5c674f1ec0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 2 Mar 2024 12:16:39 +0100 Subject: [PATCH 04/12] Update electronRebuild.yaml --- .github/workflows/electronRebuild.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/electronRebuild.yaml b/.github/workflows/electronRebuild.yaml index 90c6782586..fe9077edfe 100644 --- a/.github/workflows/electronRebuild.yaml +++ b/.github/workflows/electronRebuild.yaml @@ -9,16 +9,12 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v4 - - name: Install MagicMirror run: npm run install-mm - - name: Install @electron/rebuild - run: npm install @electron/rebuild - - name: Install some test library to be rebuilded - run: npm install onoff node-pty usb - - name: Run electron-rebuild run: npx electron-rebuild continue-on-error: false From 9f4727899ba74a51d7cf48a9742003284a08e8e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 2 Mar 2024 12:17:02 +0100 Subject: [PATCH 05/12] Update electronRebuild.yaml --- .github/workflows/electronRebuild.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/electronRebuild.yaml b/.github/workflows/electronRebuild.yaml index fe9077edfe..7e9b01744b 100644 --- a/.github/workflows/electronRebuild.yaml +++ b/.github/workflows/electronRebuild.yaml @@ -12,9 +12,9 @@ jobs: - name: Install MagicMirror run: npm run install-mm - name: Install @electron/rebuild - - run: npm install @electron/rebuild + run: npm install @electron/rebuild - name: Install some test library to be rebuilded - - run: npm install onoff node-pty usb + run: npm install onoff node-pty usb - name: Run electron-rebuild run: npx electron-rebuild continue-on-error: false From 0f0a3b073086bd0ebd7f0c45be9e71484eea4392 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 2 Mar 2024 12:21:48 +0100 Subject: [PATCH 06/12] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d8353ea0e3..1bee8b19ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ _This release is scheduled to be released on 2024-04-01._ - Output of system information to the console for troubleshooting (#3328 and #3337), ignore errors under aarch64 (#3349) - [chore] Add `eslint-plugin-package-json` to lint the `package.json` files (#3368) - weather: `showHumidity` config is now a string describing where to show this element. Supported values: "wind", "temp", "feelslike", "below", "none". (#3330) +- electron-rebuild test suite for electron and 3rd party modules compatibility (#3392) ### Updated From fb44da3297bb99001daa9a83a0e332852f7729de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 2 Mar 2024 12:34:10 +0100 Subject: [PATCH 07/12] Update electronRebuild.yaml --- .github/workflows/electronRebuild.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/electronRebuild.yaml b/.github/workflows/electronRebuild.yaml index 7e9b01744b..63fe1b36fb 100644 --- a/.github/workflows/electronRebuild.yaml +++ b/.github/workflows/electronRebuild.yaml @@ -11,10 +11,12 @@ jobs: uses: actions/checkout@v4 - name: Install MagicMirror run: npm run install-mm + - name: Test install electron v28 + run: npm install electron@28 - name: Install @electron/rebuild run: npm install @electron/rebuild - name: Install some test library to be rebuilded - run: npm install onoff node-pty usb + run: npm install onoff node-pty - name: Run electron-rebuild run: npx electron-rebuild continue-on-error: false From 2e4c62a1ff6e9d92aafd79a064b934fbc1bb91dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 2 Mar 2024 12:37:57 +0100 Subject: [PATCH 08/12] Update electronRebuild.yaml --- .github/workflows/electronRebuild.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/electronRebuild.yaml b/.github/workflows/electronRebuild.yaml index 63fe1b36fb..b0312a4e89 100644 --- a/.github/workflows/electronRebuild.yaml +++ b/.github/workflows/electronRebuild.yaml @@ -11,8 +11,6 @@ jobs: uses: actions/checkout@v4 - name: Install MagicMirror run: npm run install-mm - - name: Test install electron v28 - run: npm install electron@28 - name: Install @electron/rebuild run: npm install @electron/rebuild - name: Install some test library to be rebuilded From 5c73aba979d858365ae30219f2881fd6fef70940 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 9 Mar 2024 11:27:36 +0100 Subject: [PATCH 09/12] Update electronRebuild.yaml (testing with latest nan library) --- .github/workflows/electronRebuild.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/electronRebuild.yaml b/.github/workflows/electronRebuild.yaml index b0312a4e89..307349857b 100644 --- a/.github/workflows/electronRebuild.yaml +++ b/.github/workflows/electronRebuild.yaml @@ -15,6 +15,8 @@ jobs: run: npm install @electron/rebuild - name: Install some test library to be rebuilded run: npm install onoff node-pty + - name: Install nan@latest + run: npm install nan@latest - name: Run electron-rebuild run: npx electron-rebuild continue-on-error: false From cd62d865b1637748df35ba70b2446fc0d5c26db7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 9 Mar 2024 12:08:09 +0100 Subject: [PATCH 10/12] Update electronRebuild.yaml --- .github/workflows/electronRebuild.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/electronRebuild.yaml b/.github/workflows/electronRebuild.yaml index 307349857b..9233e652e8 100644 --- a/.github/workflows/electronRebuild.yaml +++ b/.github/workflows/electronRebuild.yaml @@ -14,9 +14,9 @@ jobs: - name: Install @electron/rebuild run: npm install @electron/rebuild - name: Install some test library to be rebuilded - run: npm install onoff node-pty - - name: Install nan@latest - run: npm install nan@latest + run: npm install onoff node-pty usb drivelist + - name: Install nan + run: npm install nan - name: Run electron-rebuild run: npx electron-rebuild continue-on-error: false From 064e594b79fdc33ec68dc33911742495e1464532 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Sat, 9 Mar 2024 12:11:34 +0100 Subject: [PATCH 11/12] Update electronRebuild.yaml (delete usb need libudev-dev package) --- .github/workflows/electronRebuild.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/electronRebuild.yaml b/.github/workflows/electronRebuild.yaml index 9233e652e8..de584dc2ce 100644 --- a/.github/workflows/electronRebuild.yaml +++ b/.github/workflows/electronRebuild.yaml @@ -14,7 +14,7 @@ jobs: - name: Install @electron/rebuild run: npm install @electron/rebuild - name: Install some test library to be rebuilded - run: npm install onoff node-pty usb drivelist + run: npm install onoff node-pty drivelist - name: Install nan run: npm install nan - name: Run electron-rebuild From 34c82c85e5ad772f730d50c1b0a2ddc6a36253d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bugsounet=20-=20C=C3=A9dric?= Date: Fri, 22 Mar 2024 21:14:05 +0100 Subject: [PATCH 12/12] Update electronRebuild.yaml (nan dep is not needed now) --- .github/workflows/electronRebuild.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/electronRebuild.yaml b/.github/workflows/electronRebuild.yaml index de584dc2ce..5c6e3f7db3 100644 --- a/.github/workflows/electronRebuild.yaml +++ b/.github/workflows/electronRebuild.yaml @@ -15,8 +15,6 @@ jobs: run: npm install @electron/rebuild - name: Install some test library to be rebuilded run: npm install onoff node-pty drivelist - - name: Install nan - run: npm install nan - name: Run electron-rebuild run: npx electron-rebuild continue-on-error: false