From e1302004c816fa410482402967602eb4550ae804 Mon Sep 17 00:00:00 2001 From: Ryan Williams Date: Wed, 18 Sep 2024 22:15:47 -0400 Subject: [PATCH 1/2] Updated new notification name to MODULE_DOM_UPDATED for clarity --- js/main.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/main.js b/js/main.js index fd70c56413..16aaa1b1b4 100644 --- a/js/main.js +++ b/js/main.js @@ -668,7 +668,7 @@ const MM = (function () { // Further implementation is done in the private method. updateDom(module, updateOptions).then(function () { // Once the update is complete and rendered, send a notification to the module that the DOM has been updated - sendNotification("DOM_OBJECTS_UPDATED", null, null, module); + sendNotification("MODULE_DOM_UPDATED", null, null, module); }); }, From 534317213c823fe146471ba1730096608b10e2f5 Mon Sep 17 00:00:00 2001 From: Ryan Williams Date: Wed, 18 Sep 2024 22:28:38 -0400 Subject: [PATCH 2/2] Updated changelog with new notification name --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1249adca22..18bb074751 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ _This release is scheduled to be released on 2024-10-01._ - [core] Add spelling check (cspell): `npm run test:spelling` and handle spelling issues (#3544) - [core] removed `config.paths.vendor` (could not work because `vendor` is hardcoded in `index.html`), renamed `config.paths.modules` to `config.foreignModulesDir`, added variable `MM_CUSTOMCSS_FILE` which - if set - overrides `config.customCss`, added variable `MM_MODULES_DIR` which - if set - overrides `config.foreignModulesDir` (#3530) - [core] elements are now removed from `index.html` when loading script or stylesheet files fails -- [core] Added `DOM_OBJECTS_UPDATED` notification each time the DOM is re-rendered via `updateDom` (#3534) +- [core] Added `MODULE_DOM_UPDATED` notification each time the DOM is re-rendered via `updateDom` (#3534) ### Removed