From b905f76af9c69984e865fa0dd4e493151237f3e9 Mon Sep 17 00:00:00 2001 From: Karsten Hassel Date: Thu, 30 Jan 2025 21:21:06 +0100 Subject: [PATCH] set name and path in module init --- CHANGELOG.md | 1 + js/app.js | 4 +--- js/node_helper.js | 7 +++++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 92c9803367..9cc1d160af 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,6 +39,7 @@ planned for 2025-04-01 - [core] Fix wrong port in log message when starting server only (#3696) - [calendar] NewYork event processed on system in Central timezone shows wrong time #3701 - [weather/yr] The Yr weather provider is now able to recover from bad API resposes instead of freezing (#3296) +- [core] Add missing name and path to node_helper init function (#3708) ## [2.30.0] - 2025-01-01 diff --git a/js/app.js b/js/app.js index ffe3616df8..c15f888560 100644 --- a/js/app.js +++ b/js/app.js @@ -210,7 +210,7 @@ function App () { Log.error(`Error when loading ${moduleName}:`, e.message); return; } - let m = new Module(); + let m = new Module(moduleName, path.resolve(moduleFolder)); if (m.requiresVersion) { Log.log(`Check MagicMirror² version for node helper '${moduleName}' - Minimum version: ${m.requiresVersion} - Current version: ${global.version}`); @@ -222,8 +222,6 @@ function App () { } } - m.setName(moduleName); - m.setPath(path.resolve(moduleFolder)); nodeHelpers.push(m); m.loaded(); diff --git a/js/node_helper.js b/js/node_helper.js index e1ecf632b5..e8971c802a 100644 --- a/js/node_helper.js +++ b/js/node_helper.js @@ -3,8 +3,11 @@ const Log = require("logger"); const Class = require("./class"); const NodeHelper = Class.extend({ - init () { - Log.log("Initializing new module helper ..."); + init (name, path) { + this.setName(name); + this.setPath(path); + + Log.log(`Initializing new module helper: ${this.name}`); }, loaded () {