Skip to content

Commit 6756d75

Browse files
authored
Merge pull request grpc#11080 from per-gron/flatbuffer-compatibility
Fix Flatbuffer compatibility issues
2 parents 746f21a + 2145897 commit 6756d75

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

src/compiler/config.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,11 @@ typedef GRPC_CUSTOM_STRINGOUTPUTSTREAM StringOutputStream;
9696
} // namespace protobuf
9797
} // namespace grpc
9898

99+
namespace grpc_cpp_generator {
100+
101+
static const char* const kCppGeneratorMessageHeaderExt = ".pb.h";
102+
static const char* const kCppGeneratorServiceHeaderExt = ".grpc.pb.h";
103+
104+
} // namespace grpc_cpp_generator
105+
99106
#endif // SRC_COMPILER_CONFIG_H

src/compiler/cpp_generator.cc

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@
4040
namespace grpc_cpp_generator {
4141
namespace {
4242

43-
grpc::string message_header_ext() { return ".pb.h"; }
44-
grpc::string service_header_ext() { return ".grpc.pb.h"; }
45-
4643
template <class T>
4744
grpc::string as_string(T x) {
4845
std::ostringstream out;
@@ -113,7 +110,7 @@ grpc::string GetHeaderPrologue(grpc_generator::File *file,
113110
vars["filename"] = file->filename();
114111
vars["filename_identifier"] = FilenameIdentifier(file->filename());
115112
vars["filename_base"] = file->filename_without_ext();
116-
vars["message_header_ext"] = message_header_ext();
113+
vars["message_header_ext"] = kCppGeneratorMessageHeaderExt;
117114

118115
printer->Print(vars, "// Generated by the gRPC C++ plugin.\n");
119116
printer->Print(vars,
@@ -128,6 +125,7 @@ grpc::string GetHeaderPrologue(grpc_generator::File *file,
128125
printer->Print(vars, "#define GRPC_$filename_identifier$__INCLUDED\n");
129126
printer->Print(vars, "\n");
130127
printer->Print(vars, "#include \"$filename_base$$message_header_ext$\"\n");
128+
printer->Print(vars, file->additional_headers().c_str());
131129
printer->Print(vars, "\n");
132130
}
133131
return output;
@@ -1039,8 +1037,8 @@ grpc::string GetSourcePrologue(grpc_generator::File *file,
10391037

10401038
vars["filename"] = file->filename();
10411039
vars["filename_base"] = file->filename_without_ext();
1042-
vars["message_header_ext"] = message_header_ext();
1043-
vars["service_header_ext"] = service_header_ext();
1040+
vars["message_header_ext"] = kCppGeneratorMessageHeaderExt;
1041+
vars["service_header_ext"] = kCppGeneratorServiceHeaderExt;
10441042

10451043
printer->Print(vars, "// Generated by the gRPC C++ plugin.\n");
10461044
printer->Print(vars,
@@ -1049,7 +1047,6 @@ grpc::string GetSourcePrologue(grpc_generator::File *file,
10491047

10501048
printer->Print(vars, "#include \"$filename_base$$message_header_ext$\"\n");
10511049
printer->Print(vars, "#include \"$filename_base$$service_header_ext$\"\n");
1052-
printer->Print(vars, file->additional_headers().c_str());
10531050
printer->Print(vars, "\n");
10541051
}
10551052
return output;
@@ -1425,8 +1422,8 @@ grpc::string GetMockPrologue(grpc_generator::File *file,
14251422

14261423
vars["filename"] = file->filename();
14271424
vars["filename_base"] = file->filename_without_ext();
1428-
vars["message_header_ext"] = message_header_ext();
1429-
vars["service_header_ext"] = service_header_ext();
1425+
vars["message_header_ext"] = kCppGeneratorMessageHeaderExt;
1426+
vars["service_header_ext"] = kCppGeneratorServiceHeaderExt;
14301427

14311428
printer->Print(vars, "// Generated by the gRPC C++ plugin.\n");
14321429
printer->Print(vars,

0 commit comments

Comments
 (0)