Skip to content

Improve ARM extracting #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vainiovano wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve ARM extracting #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e73e249
extractors: Detect arm64 as ARM 64Bit
vainiovano Dec 19, 2023
87d9eb8
extractors: Pass ARM generations through
vainiovano Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/feedback_plugin/data_processing/extractors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,8 @@ def extract_machine_architecture(upload: dict[str, list[str]]) -> str:
elif re.match('^[ix][3-6]*86$', machine):
# This check must happen after x86_64
machine_architecture = 'x86'
elif re.match('^armv[5-7]', machine):
machine_architecture = 'ARM 32Bit'
elif re.match('^aarch64$', machine):
machine_architecture = 'ARM 64Bit'
elif re.match('^(aarch64|arm64)$', machine):
machine_architecture = 'armv8'
elif re.match('^hp_', machine):
machine_architecture = 'HP Itanium'
elif re.match('^alpha', machine):
Expand Down