From 1e3fef3dda0e982d2bed845eef5b11424323c145 Mon Sep 17 00:00:00 2001
From: jonahtanjz <jonahtanjz4884@gmail.com>
Date: Thu, 28 Jan 2021 13:05:47 +0800
Subject: [PATCH 1/4] Enable linting for dropdown.vue

---
 .eslintignore                            |   1 -
 packages/vue-components/src/Dropdown.vue | 176 ++++++++++++-----------
 2 files changed, 94 insertions(+), 83 deletions(-)

diff --git a/.eslintignore b/.eslintignore
index ba6fa27f75..ba48e019fd 100644
--- a/.eslintignore
+++ b/.eslintignore
@@ -14,7 +14,6 @@ packages/vue-components/src/utils/NodeList.js
 packages/vue-components/src/utils/utils.js
 
 # yuche/vue-strap
-packages/vue-components/src/Dropdown.vue
 packages/vue-components/src/main.js
 packages/vue-components/src/Navbar.vue
 packages/vue-components/src/Tab.vue
diff --git a/packages/vue-components/src/Dropdown.vue b/packages/vue-components/src/Dropdown.vue
index b031626e9f..15fa0edb52 100644
--- a/packages/vue-components/src/Dropdown.vue
+++ b/packages/vue-components/src/Dropdown.vue
@@ -1,14 +1,24 @@
 <template>
-  <li v-if="isLi" ref="dropdown" :class="classes">
+  <li
+    v-if="isLi"
+    ref="dropdown"
+    :class="[{ 'disabled': disabledBool },
+             isLi ? 'dropdown' : 'btn-group', addClass]"
+  >
     <slot name="button">
-      <a class="dropdown-toggle" role="button" :class="{disabled: disabled}" @keyup.esc="hideDropdownMenu()">
+      <a
+        class="dropdown-toggle"
+        role="button"
+        :class="{disabled: disabled}"
+        @keyup.esc="hideDropdownMenu()"
+      >
         <slot name="_header">
           <slot name="header"></slot>
         </slot>
       </a>
     </slot>
-    <slot name="dropdown-menu" :class="menuClasses">
-      <ul class="dropdown-menu" :class="menuClasses">
+    <slot name="dropdown-menu" :class="[{ 'show': showBool }, { 'dropdown-menu-right': menuAlignRight }]">
+      <ul class="dropdown-menu" :class="[{ 'show': showBool }, { 'dropdown-menu-right': menuAlignRight }]">
         <slot></slot>
       </ul>
     </slot>
@@ -18,17 +28,28 @@
       <slot :name="name"></slot>
     </template>
   </submenu>
-  <div v-else ref="dropdown" :class="classes">
+  <div
+    v-else
+    ref="dropdown"
+    :class="[{ 'disabled': disabledBool },
+             isLi ? 'dropdown' : 'btn-group', addClass]"
+  >
     <slot name="before"></slot>
     <slot name="button">
-      <button type="button" class="btn dropdown-toggle" :class="[btnType, btnWithBefore]" @keyup.esc="hideDropdownMenu()" :disabled="disabled">
+      <button
+        type="button"
+        class="btn dropdown-toggle"
+        :class="[btnType, btnWithBefore]"
+        :disabled="disabled"
+        @keyup.esc="hideDropdownMenu()"
+      >
         <slot name="_header">
           <slot name="header"></slot>
         </slot>
       </button>
     </slot>
-    <slot name="dropdown-menu" :class="menuClasses">
-      <ul class="dropdown-menu" :class="menuClasses">
+    <slot name="dropdown-menu" :class="[{ 'show': showBool }, { 'dropdown-menu-right': menuAlignRight }]">
+      <ul class="dropdown-menu" :class="[{ 'show': showBool }, { 'dropdown-menu-right': menuAlignRight }]">
         <slot></slot>
       </ul>
     </slot>
@@ -36,63 +57,54 @@
 </template>
 
 <script>
-import {toBoolean} from './utils/utils.js'
-import $ from './utils/NodeList.js'
+import { toBoolean } from './utils/utils';
+import $ from './utils/NodeList';
 
 export default {
   props: {
-    show: {
-      type: Boolean,
-      default: false
-    },
-    'class': null,
     disabled: {
       type: Boolean,
-      default: false
+      default: false,
     },
     type: {
       type: String,
-      default: 'light'
+      default: 'light',
     },
     menuAlignRight: {
       type: Boolean,
-      default: false
+      default: false,
     },
     addClass: {
       type: String,
-      default: ''
-    }
+      default: '',
+    },
   },
   provide: { hasParentDropdown: true },
   inject: ['hasParentDropdown'],
+  data() {
+    return {
+      show: false,
+    };
+  },
   computed: {
-    btnType () {
+    btnType() {
       return `btn-${this.type}`;
     },
-    classes () {
-      return [{disabled: this.disabledBool}, this.class, this.isLi ? 'dropdown' : 'btn-group', this.addClass]
-    },
-    menuClasses() {
-      return [{show: this.showBool}, {'dropdown-menu-right': this.menuAlignRight}];
-    },
     disabledBool() {
       return toBoolean(this.disabled);
     },
-    isLi () { return this.$parent._navbar || this.$parent.menu || this.$parent._tabset },
-    isSubmenu() { return this.hasParentDropdown },
-    menu () {
-      return !this.$parent || this.$parent.navbar
+    isLi() { return this.$parent._navbar || this.$parent.menu || this.$parent._tabset; },
+    isSubmenu() { return this.hasParentDropdown; },
+    menu() {
+      return !this.$parent || this.$parent.navbar;
     },
-    showBool() {
-      return toBoolean(this.show);
+    submenu() {
+      return this.$parent && (this.$parent.menu || this.$parent.submenu);
     },
-    submenu () {
-      return this.$parent && (this.$parent.menu || this.$parent.submenu)
+    slots() {
+      return this.$slots.default;
     },
-    slots () {
-      return this.$slots.default
-    },
-    btnWithBefore () {
+    btnWithBefore() {
       if (this.$slots.before) {
         return 'btn-with-before';
       }
@@ -100,17 +112,17 @@ export default {
     },
   },
   methods: {
-    blur () {
-      this.unblur()
+    blur() {
+      this.unblur();
       this._hide = setTimeout(() => {
-        this._hide = null
+        this._hide = null;
         this.hideDropdownMenu();
-      }, 100)
+      }, 100);
     },
-    unblur () {
+    unblur() {
       if (this._hide) {
-        clearTimeout(this._hide)
-        this._hide = null
+        clearTimeout(this._hide);
+        this._hide = null;
       }
     },
     hideDropdownMenu() {
@@ -120,16 +132,16 @@ export default {
     showDropdownMenu() {
       this.show = true;
       $(this.$refs.dropdown).findChildren('ul').each(ul => ul.classList.toggle('show', true));
-    }
+    },
   },
-  mounted () {
-    const $el = $(this.$refs.dropdown)
+  mounted() {
+    const $el = $(this.$refs.dropdown);
     if (this.show) {
       this.showDropdownMenu();
     }
-    $el.onBlur((e) => { this.hideDropdownMenu() }, false)
-    $el.findChildren('a,button.dropdown-toggle').on('click', e => {
-      e.preventDefault()
+    $el.onBlur(() => { this.hideDropdownMenu(); }, false);
+    $el.findChildren('a,button.dropdown-toggle').on('click', (e) => {
+      e.preventDefault();
       if (this.disabledBool) { return false; }
       if (this.showBool) {
         this.hideDropdownMenu();
@@ -137,41 +149,41 @@ export default {
         this.showDropdownMenu();
       }
       return false;
-    })
-    $el.findChildren('ul').on('click', 'li>a', e => { 
-      if (e.target.classList.contains('submenu-toggle')) { return }
+    });
+    $el.findChildren('ul').on('click', 'li>a', (e) => {
+      if (e.target.classList.contains('submenu-toggle')) { return; }
       this.hideDropdownMenu();
-    })
+    });
+  },
+  beforeDestroy() {
+    const $el = $(this.$refs.dropdown);
+    $el.offBlur();
+    $el.findChildren('a,button').off();
+    $el.findChildren('ul').off();
   },
-  beforeDestroy () {
-    const $el = $(this.$refs.dropdown)
-    $el.offBlur()
-    $el.findChildren('a,button').off()
-    $el.findChildren('ul').off()
-  }
-}
+};
 </script>
 
 <style scoped>
-.secret {
-  position: absolute;
-  clip: rect(0 0 0 0);
-  overflow: hidden;
-  margin: -1px;
-  height: 1px;
-  width: 1px;
-  padding: 0;
-  border: 0;
-}
+    .secret {
+        position: absolute;
+        clip: rect(0 0 0 0);
+        overflow: hidden;
+        margin: -1px;
+        height: 1px;
+        width: 1px;
+        padding: 0;
+        border: 0;
+    }
 
-.btn-with-before {
-  padding-left: 0.2rem;
-  padding-right: 0.4rem;
-}
+    .btn-with-before {
+        padding-left: 0.2rem;
+        padding-right: 0.4rem;
+    }
 
-.dropdown-toggle {
-  cursor: pointer;
-  color: inherit;
-  text-decoration: none;
-}
+    .dropdown-toggle {
+        cursor: pointer;
+        color: inherit;
+        text-decoration: none;
+    }
 </style>

From 3c41aae9e21b40b1c7c073d5942be5b2db512b00 Mon Sep 17 00:00:00 2001
From: jonahtanjz <jonahtanjz4884@gmail.com>
Date: Thu, 28 Jan 2021 13:22:36 +0800
Subject: [PATCH 2/4] Remove instances of showBool

---
 packages/vue-components/src/Dropdown.vue | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/vue-components/src/Dropdown.vue b/packages/vue-components/src/Dropdown.vue
index 15fa0edb52..fbe8c977c0 100644
--- a/packages/vue-components/src/Dropdown.vue
+++ b/packages/vue-components/src/Dropdown.vue
@@ -17,8 +17,8 @@
         </slot>
       </a>
     </slot>
-    <slot name="dropdown-menu" :class="[{ 'show': showBool }, { 'dropdown-menu-right': menuAlignRight }]">
-      <ul class="dropdown-menu" :class="[{ 'show': showBool }, { 'dropdown-menu-right': menuAlignRight }]">
+    <slot name="dropdown-menu" :class="[{ 'show': show }, { 'dropdown-menu-right': menuAlignRight }]">
+      <ul class="dropdown-menu" :class="[{ 'show': show }, { 'dropdown-menu-right': menuAlignRight }]">
         <slot></slot>
       </ul>
     </slot>
@@ -48,8 +48,8 @@
         </slot>
       </button>
     </slot>
-    <slot name="dropdown-menu" :class="[{ 'show': showBool }, { 'dropdown-menu-right': menuAlignRight }]">
-      <ul class="dropdown-menu" :class="[{ 'show': showBool }, { 'dropdown-menu-right': menuAlignRight }]">
+    <slot name="dropdown-menu" :class="[{ 'show': show }, { 'dropdown-menu-right': menuAlignRight }]">
+      <ul class="dropdown-menu" :class="[{ 'show': show }, { 'dropdown-menu-right': menuAlignRight }]">
         <slot></slot>
       </ul>
     </slot>
@@ -143,7 +143,7 @@ export default {
     $el.findChildren('a,button.dropdown-toggle').on('click', (e) => {
       e.preventDefault();
       if (this.disabledBool) { return false; }
-      if (this.showBool) {
+      if (this.show) {
         this.hideDropdownMenu();
       } else {
         this.showDropdownMenu();

From 492ce58df300f41e5351c1ecc13ef817d73ef7eb Mon Sep 17 00:00:00 2001
From: jonahtanjz <jonahtanjz4884@gmail.com>
Date: Thu, 28 Jan 2021 16:35:24 +0800
Subject: [PATCH 3/4] Change all disabled to use computed value

---
 packages/vue-components/src/Dropdown.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/vue-components/src/Dropdown.vue b/packages/vue-components/src/Dropdown.vue
index fbe8c977c0..a018f62561 100644
--- a/packages/vue-components/src/Dropdown.vue
+++ b/packages/vue-components/src/Dropdown.vue
@@ -9,7 +9,7 @@
       <a
         class="dropdown-toggle"
         role="button"
-        :class="{disabled: disabled}"
+        :class="{'disabled': disabledBool}"
         @keyup.esc="hideDropdownMenu()"
       >
         <slot name="_header">
@@ -40,7 +40,7 @@
         type="button"
         class="btn dropdown-toggle"
         :class="[btnType, btnWithBefore]"
-        :disabled="disabled"
+        :disabled="disabledBool"
         @keyup.esc="hideDropdownMenu()"
       >
         <slot name="_header">

From 77c07447a545d6ae33f4fda59fdc5ecff718155a Mon Sep 17 00:00:00 2001
From: jonahtanjz <jonahtanjz4884@gmail.com>
Date: Sat, 30 Jan 2021 13:26:55 +0800
Subject: [PATCH 4/4] Enable stylelint for Dropdown.vue

---
 .stylelintignore | 25 +++++++++++++++++++++++++
 .stylelintrc.js  |  2 +-
 package.json     |  4 ++--
 3 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/.stylelintignore b/.stylelintignore
index e3ccae354a..c10b20f990 100644
--- a/.stylelintignore
+++ b/.stylelintignore
@@ -2,3 +2,28 @@
 **/_site/**/*.css
 packages/cli/test/functional/**/expected/**/*.css
 packages/vue-components/**/*.css
+
+# --- packages/vue-components .vue files ---
+
+packages/vue-components/src/Navbar.vue
+packages/vue-components/src/Panel.vue
+packages/vue-components/src/Pic.vue
+packages/vue-components/src/Retriever.vue
+packages/vue-components/src/Searchbar.vue
+packages/vue-components/src/SearchbarPageItem.vue
+packages/vue-components/src/SiteNav.vue
+packages/vue-components/src/Submenu.vue
+packages/vue-components/src/Tab.vue
+packages/vue-components/src/TabGroup.vue
+packages/vue-components/src/Tabset.vue
+packages/vue-components/src/Thumbnail.vue
+packages/vue-components/src/TipBox.vue
+packages/vue-components/src/Trigger.vue
+packages/vue-components/src/panels/MinimalPanel.vue
+packages/vue-components/src/panels/NestedPanel.vue
+packages/vue-components/src/panels/PanelSwitch.vue
+packages/vue-components/src/questions/QOption.vue
+packages/vue-components/src/questions/Question.vue
+packages/vue-components/src/questions/Quiz.vue
+
+# --- packages/vue-components end ---
diff --git a/.stylelintrc.js b/.stylelintrc.js
index 366f78a0f2..00a2e1073e 100644
--- a/.stylelintrc.js
+++ b/.stylelintrc.js
@@ -1,7 +1,7 @@
 module.exports = {
   "extends": "stylelint-config-standard",
   "rules": {
-    "indentation": 4,
+    "indentation": [ 4, { baseIndentLevel: 1 } ],
     // MarkBind generates some blank CSS files when initialising a site,
     // which violates the no-empty-source rule
     "no-empty-source": null
diff --git a/package.json b/package.json
index 9bc2e2cbaa..aa6950d3ec 100644
--- a/package.json
+++ b/package.json
@@ -3,8 +3,8 @@
   "private": true,
   "scripts": {
     "build:web": "cd packages/core-web && npm run build",
-    "csslint": "stylelint **/*.css",
-    "csslintfix": "stylelint **/*.css --fix",
+    "csslint": "stylelint **/*.css **/*.vue",
+    "csslintfix": "stylelint **/*.css **/*.vue --fix",
     "lint": "eslint . --ext .js,.vue && npm run csslint",
     "lintfix": "eslint . --ext .js,.vue --fix && npm run csslintfix",
     "setup": "npm ci && lerna clean --yes && lerna bootstrap --hoist",