From 2440d3f1448ecfae58c87c96ef8de43687d37c1c Mon Sep 17 00:00:00 2001 From: tlylt Date: Tue, 22 Mar 2022 17:36:23 +0800 Subject: [PATCH 1/2] Update dep --- packages/cli/package.json | 4 ++-- packages/core-web/package.json | 2 +- packages/core/package.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/cli/package.json b/packages/cli/package.json index a252d3f861..375d27d5ce 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -25,8 +25,8 @@ "updatetest": "cd test/functional && node updatetest.js" }, "dependencies": { - "@markbind/core": "^3.1.1", - "@markbind/core-web": "^3.1.1", + "@markbind/core": "3.1.1", + "@markbind/core-web": "3.1.1", "bluebird": "^3.7.2", "chalk": "^3.0.0", "cheerio": "^0.22.0", diff --git a/packages/core-web/package.json b/packages/core-web/package.json index 7340c0bf0a..1f92f8b8ad 100644 --- a/packages/core-web/package.json +++ b/packages/core-web/package.json @@ -30,7 +30,7 @@ "@babel/plugin-transform-runtime": "^7.10.5", "@babel/preset-env": "^7.10.4", "@babel/runtime": "^7.10.5", - "@markbind/vue-components": "^3.1.1", + "@markbind/vue-components": "3.1.1", "babel-loader": "^8.1.0", "bootstrap-vue": "^2.16.0", "cross-env": "^7.0.3", diff --git a/packages/core/package.json b/packages/core/package.json index bdc6db79cb..bb4d7be2a2 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -25,7 +25,7 @@ }, "dependencies": { "@fortawesome/fontawesome-free": "^5.15.4", - "@markbind/core-web": "^3.1.1", + "@markbind/core-web": "3.1.1", "@primer/octicons": "^15.0.1", "@sindresorhus/slugify": "^0.9.1", "bluebird": "^3.7.2", From 938d18bf811467dff48472953af5a202e713d79e Mon Sep 17 00:00:00 2001 From: tlylt Date: Tue, 22 Mar 2022 20:35:57 +0800 Subject: [PATCH 2/2] Update dev docs --- docs/devGuide/projectManagement.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/devGuide/projectManagement.md b/docs/devGuide/projectManagement.md index 96f804647e..fc626b20be 100644 --- a/docs/devGuide/projectManagement.md +++ b/docs/devGuide/projectManagement.md @@ -80,11 +80,12 @@ For general best practices, refer to the guide [_Working with PRs_ @SE-EDU](http 1. **Make sure to start with a "clean slate"** by running `lerna clean` and then `npm run setup` in the root MarkBind directory. -1. **Increment the version number** by running `lerna version --no-push`. Which to increment (`patch`, `minor` or `major`) depends on what PRs are merged for the new version, which means you must know beforehand about the changes. +1. **Increment the version number** by running `lerna version --no-push --exact`. Which to increment (`patch`, `minor` or `major`) depends on what PRs are merged for the new version, which means you must know beforehand about the changes. - - The end result of this command is version commit with an appropriate tag. We will make use of the generated tag and commit message later. + + * We will specify updated version numbers exactly to ensure that each version will consistently fetch the same versioned internal packages. + * The end result of this command is version commit with an appropriate tag. We will make use of the generated tag and commit message later. 1. **Build the core-web package bundle** by executing `npm run build:web` in the root directory, after which you should see changes in the bundles located in `packages/core-web/dist`.

Take a peek at the diff for the bundles to see if there are any strange changes.