From 5fc1e69c193f3ec155662d8c2ae8b624f41935b5 Mon Sep 17 00:00:00 2001 From: Wang Yiwen Date: Fri, 29 Mar 2024 18:37:21 +0800 Subject: [PATCH 1/2] Rename markdown-it-icons.test.js to typescript --- .../unit/{markdown-it-icons.test.js => markdown-it-icons.test.ts} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename packages/core/test/unit/{markdown-it-icons.test.js => markdown-it-icons.test.ts} (100%) diff --git a/packages/core/test/unit/markdown-it-icons.test.js b/packages/core/test/unit/markdown-it-icons.test.ts similarity index 100% rename from packages/core/test/unit/markdown-it-icons.test.js rename to packages/core/test/unit/markdown-it-icons.test.ts From 16447bb096d3494c864b8da405390345c634f2b6 Mon Sep 17 00:00:00 2001 From: Wang Yiwen Date: Fri, 29 Mar 2024 18:49:07 +0800 Subject: [PATCH 2/2] Adapt markdown-it-icons.test.js to typescript Rename markdown-it-icons.test.js to typescript --- .eslintignore | 3 --- .gitignore | 3 --- packages/core/test/unit/markdown-it-icons.test.ts | 5 +++-- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/.eslintignore b/.eslintignore index f5dda8b156..1bf59375c8 100644 --- a/.eslintignore +++ b/.eslintignore @@ -25,9 +25,6 @@ packages/core/src/utils/*.js packages/core/src/variables/*.js packages/core/test/unit/**/*.js -# TODO: remove when migrated to TS -!markdown-it-icons.test.js - # Rules for pure JS files packages/core/src/lib/markdown-it/patches/* packages/core/src/lib/markdown-it/plugins/* diff --git a/.gitignore b/.gitignore index 407c29d93c..ff59cd5fff 100644 --- a/.gitignore +++ b/.gitignore @@ -90,7 +90,4 @@ packages/core/src/utils/*.js packages/core/src/variables/*.js packages/core/test/unit/**/*.js -# TODO: remove when migrated to TS -!markdown-it-icons.test.js - # --- packages/core end --- diff --git a/packages/core/test/unit/markdown-it-icons.test.ts b/packages/core/test/unit/markdown-it-icons.test.ts index 497879bd6d..2fbb64fa3e 100644 --- a/packages/core/test/unit/markdown-it-icons.test.ts +++ b/packages/core/test/unit/markdown-it-icons.test.ts @@ -1,6 +1,7 @@ -const expectedOcticon = require('@primer/octicons')['git-pull-request'].toSVG(); +import octicons from '@primer/octicons'; +import markdownIt from '../../src/lib/markdown-it'; -const markdownIt = require('../../src/lib/markdown-it'); +const expectedOcticon = octicons['git-pull-request'].toSVG(); test('markdown-it-icons renders icon syntax correctly', () => { const source = ':fab-font-awesome: :glyphicon-home: :octicon-git-pull-request: :mit-task-alt:';