|
| 1 | +<!-- |
| 2 | +
|
| 3 | +Thanks for wanting to contribute to RMM :) Please read these instructions and |
| 4 | +replace them with your description. |
| 5 | +
|
| 6 | +First, if you need some help or want to chat to the core developers, please |
| 7 | +visit https://rapids.ai/community.html for links to our Google Group and other |
| 8 | +communication channels. |
| 9 | +
|
| 10 | +Here's some guidelines to help the review process go smoothly. |
| 11 | +
|
| 12 | +0. Please write a description in this text box of the changes that are being |
| 13 | + made. |
| 14 | +
|
| 15 | +1. Please ensure that you have written units tests for the changes made and/or |
| 16 | + features added. |
| 17 | +
|
| 18 | +2. If you are closing an issue please use one of the automatic closing words as |
| 19 | + noted here: https://help.github.com/articles/closing-issues-using-keywords/ |
| 20 | +
|
| 21 | +3. If your pull request is not ready for review but you want to make use of the |
| 22 | + continuous integration testing facilities please label it with `[WIP]`. |
| 23 | +
|
| 24 | +4. If your pull request is ready to be reviewed without requiring additional |
| 25 | + work on top of it, then remove the `[WIP]` label (if present) and replace |
| 26 | + it with `[REVIEW]`. If assistance is required to complete the functionality, |
| 27 | + for example when the C/C++ code of a feature is complete but Python bindings |
| 28 | + are still required, then add the label `[HELP-REQ]` so that others can triage |
| 29 | + and assist. The additional changes then can be implemented on top of the |
| 30 | + same PR. If the assistance is done by members of the rapidsAI team, then no |
| 31 | + additional actions are required by the creator of the original PR for this, |
| 32 | + otherwise the original author of the PR needs to give permission to the |
| 33 | + person(s) assisting to commit to their personal fork of the project. If that |
| 34 | + doesn't happen then a new PR based on the code of the original PR can be |
| 35 | + opened by the person assisting, which then will be the PR that will be |
| 36 | + merged. |
| 37 | +
|
| 38 | +5. Once all work has been done and review has taken place please do not add |
| 39 | + features or make changes out of the scope of those requested by the reviewer |
| 40 | + (doing this just adds delays as already reviewed code ends up having to be |
| 41 | + re-reviewed/it is hard to tell what is new etc!). Further, please do not |
| 42 | + rebase your branch on master/force push/rewrite history, doing any of these |
| 43 | + causes the context of any comments made by reviewers to be lost. If |
| 44 | + conflicts occur against the release or master branch they should be resolved |
| 45 | + by merging master into the branch used for making the pull request. |
| 46 | +
|
| 47 | +Many thanks in advance for your cooperation! |
| 48 | +
|
| 49 | +--> |
0 commit comments