Correctly asserting up/down

Author: oxisto

Tests/Container-Compose-DynamicTests/ComposeDownTests.swift

@@ -26,34 +26,38 @@ struct ComposeDownTests {
 
     @Test("What goes up must come down - container_name")
       func testUpAndDownContainerName() async throws  {
-        let yaml = DockerComposeYamlFiles.dockerComposeYaml1
+        // Create a new temporary UUID to use as a container name, otherwise we might conflict with
+        // existing containers on the system
+        let containerName  = UUID().uuidString
+
+        let yaml = DockerComposeYamlFiles.dockerComposeYaml9(containerName: containerName)
 
         let tempLocation = URL.temporaryDirectory.appending(path: "Container-Compose_Tests_\(UUID().uuidString)/docker-compose.yaml")
         let tempBase = tempLocation.deletingLastPathComponent()
         try? FileManager.default.createDirectory(at: tempLocation.deletingLastPathComponent(), withIntermediateDirectories: true)
         try yaml.write(to: tempLocation, atomically: false, encoding: .utf8)
-        let folderName = tempBase.lastPathComponent
 
         var composeUp = try ComposeUp.parse(["-d", "--cwd", tempBase.path(percentEncoded: false)])
         try await composeUp.run()
-
+        
         var containers = try await ClientContainer.list()
             .filter({
-                $0.configuration.id.contains(folderName)
+                $0.configuration.id.contains(containerName)
             })
 
-        #expect(containers.count == 1, "Expected 1 containers to be running, found \(containers.count)")
-        //#expect(containers[0].configuration.names.contains("/custom_nginx"), "Expected container to have name /custom_nginx, found \(containers[0].configuration.names)")
+        #expect(containers.count == 1, "Expected 1 container with the name \(containerName), found \(containers.count)")
+        #expect(containers[0].status == .running, "Expected container \(containerName) to be running, found status: \(containers[0].status.rawValue)")
 
         var composeDown = try ComposeDown.parse(["--cwd", tempBase.path(percentEncoded: false)])
         try await composeDown.run()
 
         containers = try await ClientContainer.list()
             .filter({
-                $0.configuration.id.contains(folderName)
+                $0.configuration.id.contains(containerName)
             })
 
-        #expect(containers.count == 0, "Expected no containers to be running, found \(containers.count)")
+        #expect(containers.count == 1, "Expected 1 container with the name \(containerName), found \(containers.count)")
+        #expect(containers[0].status == .stopped, "Expected container \(containerName) to be stopped, found status: \(containers[0].status.rawValue)")
     }
 
 }