Skip to content

add singularize/pluralize overload without using obsolete plurality enum#306

Merged
MehdiK merged 5 commits into
Humanizr:masterfrom
mexx:singularize-pluralize-obsolete-plurality
Jun 27, 2014
Merged

add singularize/pluralize overload without using obsolete plurality enum#306
MehdiK merged 5 commits into
Humanizr:masterfrom
mexx:singularize-pluralize-obsolete-plurality

Conversation

@mexx

@mexx mexx commented Jun 24, 2014

Copy link
Copy Markdown
Contributor

related to #234

@mexx mexx changed the title add singularize/pluralize overlead without using obsolete plurality enum add singularize/pluralize overload without using obsolete plurality enum Jun 24, 2014
@MehdiK

MehdiK commented Jun 24, 2014

Copy link
Copy Markdown
Collaborator

Thanks @mexx. Please flag the obsolete methods as Obsolete, update all the usages in Humanizer codebase and add this to readme as preferred API mentioning we will remove the old API in V2.

Comment thread readme.md

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better API. Thanks for the suggestion and for fixing it.

MehdiK added a commit that referenced this pull request Jun 27, 2014
…ality

add singularize/pluralize overload without using obsolete plurality enum
@MehdiK MehdiK merged commit 6808e22 into Humanizr:master Jun 27, 2014
@MehdiK

MehdiK commented Jun 27, 2014

Copy link
Copy Markdown
Collaborator

Good PR @mexx. Thanks.

@MehdiK MehdiK mentioned this pull request Jun 27, 2014
@MehdiK

MehdiK commented Jul 7, 2014

Copy link
Copy Markdown
Collaborator

This is now available on NuGet as v1.28.0. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants