adds missing resources/tests for the Romanian locale#356
Conversation
|
In regards to the modification of the RomanianFormatter, I suppose I should add the motivation behind why I decided to change it: I just wanted Humanizer to work for the Romanian culture but some resources were missing which had the consequence of calls to Humanize blowing up. I quickly decided to add the missing resources but as soon as I did this I became bored of having to add the same resource twice (once with and once without the preposition) so I figured there must be a better way to do this (which I think I implemented). Also I think the existing GetResourceKey implementation (in the RomanianFormatter) is quite opaque and one doesn't really understand why it's doing what it does. Anyway, I'm open to a discussion on this. |
… RomanianFormatter so as to make it clearer what's happening and remove resource duplication
|
This is clean and nice. No need for discussion. Thanks for the addition. |
adds missing resources/tests for the Romanian locale
|
Thanks for the contribution. This is now available on NuGet as v1.32. |
|
My pleasure. I'm always glad when I can give back to the Open Source community. Thanks for the update. |
Also modifies the RomanianFormatter so as to make it clearer what's happening and remove resource duplication