Skip to content

Update Resources.ar.resx#231

Merged
MehdiK merged 3 commits into
Humanizr:masterfrom
kikoanis:master
Apr 18, 2014
Merged

Update Resources.ar.resx#231
MehdiK merged 3 commits into
Humanizr:masterfrom
kikoanis:master

Conversation

@kikoanis

Copy link
Copy Markdown
Contributor

Added more settings for FromNow, Dual and Plural

@MehdiK

MehdiK commented Apr 18, 2014

Copy link
Copy Markdown
Collaborator

Please write unit tests for the added resources. Here is some examples.

Also add your PR to the release-notes file. Thanks.

@kikoanis

Copy link
Copy Markdown
Contributor Author

Done... Thanks

MehdiK added a commit that referenced this pull request Apr 18, 2014
@MehdiK MehdiK merged commit 76cc483 into Humanizr:master Apr 18, 2014
@MehdiK

MehdiK commented Apr 18, 2014

Copy link
Copy Markdown
Collaborator

Cool. Thanks for the addition.

@MehdiK

MehdiK commented Apr 18, 2014

Copy link
Copy Markdown
Collaborator

If you're interested ToWords and ToOrdinalWords can be localised too! From the contribution guideline:

Translations for ToWords and ToOrdinalWords methods are currently done in code as there is a huge difference between the way different languages deal with number words. Check out Dutch and Russian localisations for examples of how you can write a Converter for your language. You should then register your converter in the ConverterFactory for it to kick in on your locale.

Don't forget to write tests for your localisations. Check out the existing DateHumanizeTests, TimeSpanHumanizeTests and NumberToWordsTests.

@MehdiK

MehdiK commented Apr 19, 2014

Copy link
Copy Markdown
Collaborator

Thanks for the contribution. This is now available on NuGet as v1.23.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants