Update Working Practices with LFRic Apps instructions#144
Merged
Conversation
Jenny Hickson (jennyhickson)
requested review from
a team,
Giorgia (GiorgiaLine) and
R Sharp (r-sharp)
and removed request for
a team and
R Sharp (r-sharp)
Giorgia (GiorgiaLine)
approved these changes
Mar 5, 2024
Giorgia (GiorgiaLine)
left a comment
Giorgia (GiorgiaLine)
left a comment
There was a problem hiding this comment.
All looks good to me, approved for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding instructions for LFRic Apps and clarifying those for LFRic Core where appropriate.
This PR covers most of the items on the list in #111. It does not include metadata changes (these are better done once #138 has been committed.
I also haven't modified the "recent changes" section - adding Apps is a major change but I'm not sure on the best way of documenting these given this page hasn't been updated since launch. Perhaps it would be better to do a release of the working practices with each release cycle (at least the releases where there have been changes) and then the release notes would document these things? If we don't want to go that route then a further PR to document all recent changes would be a good way to catch up.